Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add a changelog section on hompage #1907

Open
wants to merge 5 commits into
base: prod
Choose a base branch
from
Open

Feat: Add a changelog section on hompage #1907

wants to merge 5 commits into from

Conversation

thisisobate
Copy link
Contributor

@thisisobate thisisobate commented Dec 26, 2024 •
edited
Loading

Todo

  • make the changelog section look nicer on mobile

Fixes #1851

@thisisobate
Copy link
Contributor Author

@frouioui

@netlify Netlify
Copy link

netlify bot commented Dec 26, 2024

✅ Deploy Preview for vitess ready!

Name Link
🔨 Latest commit f09c2e4
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/676d43582c4ea00008e0d785
😎 Deploy Preview https://deploy-preview-1907--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@deepthi
Copy link
Member

deepthi commented Dec 31, 2024

I like this! One suggestion I have though is not to use release blog posts in the changelog. Instead, can you use the following?

shlomi-noach
shlomi-noach reviewed Dec 31, 2024
View reviewed changes
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for working on this. I will echo @deepthi's comments. I also think we may as well retroactively generate some changelog entires based on Vitess changelog commits.

@thisisobate
Copy link
Contributor Author

thisisobate commented Dec 31, 2024 •
edited
Loading

I also think we may as well retroactively generate some changelog entires based on Vitess changelog commits

Sweet! I imagine we will have to do some docs pre-processing to make this work? I don't know. We can always play around and improve this workflow. Let's do this in a separate PR if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Changelog section to the front page
3 participants
@thisisobate @deepthi @shlomi-noach