-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
chore(deps/v7): update esbuild from 0.25.0 to 0.27.0 #21183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v7
Are you sure you want to change the base?
Conversation
|
I was going to raise an issue about this (still happy to if it's preferable to discuss there rather than in a PR). For me, the main motivation to do this would be to address various golang stdlib vulnerabilities that were fixed in 0.27.0. See evanw/esbuild#4311. |
1d3f905 to
bfe35c4
Compare
|
we might want to specify otherwise projects that can't move off esbuild 0.25.0 yet will end up installing two copies or we can just let them install 2 copies in the hope they notice and upgrade... 😅 |
|
Also, should I make the same PR to vite v6 ? |
30ef934 to
519d892
Compare
✅ Deploy Preview for vite-docs-v7 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
We can just bump to 0.27.0 as we've done the same in the past. This'll likely be merged shortly after as a small v7 minor. |
|
Ok, thank you, if there is anything else I need to do or change just tell me |
No you can not do that anyways because minor v0 versions are considered incompatible to each other.
And I'm in the opposite situation where another project (storybook) installs 0.27 but vite lags behind resulting in the duplicate. |
Just to be clear, you can do that. Yes, a minor 0.x version is basically a major. But we know these three versions of esbuild are compatible, and that's what the OR is for. Though I agree with Bjorn now, that we should just bump the version. |
|
Yeah I think ultimately esbuild it to blame that they are still on |
Update esbuild to 0.27.0
2b39082 to
e64cc9f
Compare
Update esbuild from 0.25.0 to 0.27.0
Update the iife tests to match esbuild behaviour