Skip to content

Conversation

@GameRoMan
Copy link

@GameRoMan GameRoMan commented Dec 1, 2025

Update esbuild from 0.25.0 to 0.27.0

Update the iife tests to match esbuild behaviour

@askoufis
Copy link
Contributor

askoufis commented Dec 1, 2025

I was going to raise an issue about this (still happy to if it's preferable to discuss there rather than in a PR).

For me, the main motivation to do this would be to address various golang stdlib vulnerabilities that were fixed in 0.27.0. See evanw/esbuild#4311.

@GameRoMan GameRoMan force-pushed the chore/v7/update-esbuild branch from 1d3f905 to bfe35c4 Compare December 2, 2025 10:51
@GameRoMan GameRoMan changed the title chore(deps): Update esbuild to 0.27.0 chore(deps): update esbuild from 0.25.0 to 0.27.0 Dec 2, 2025
@43081j
Copy link
Contributor

43081j commented Dec 2, 2025

we might want to specify ^0.25.0 || ^0.26.0 || ^0.27.0 or some such thing

otherwise projects that can't move off esbuild 0.25.0 yet will end up installing two copies

or we can just let them install 2 copies in the hope they notice and upgrade... 😅

@GameRoMan
Copy link
Author

Also, should I make the same PR to vite v6 ?

@sapphi-red sapphi-red changed the base branch from main to v7 December 3, 2025 08:08
@GameRoMan GameRoMan force-pushed the chore/v7/update-esbuild branch from 30ef934 to 519d892 Compare December 4, 2025 09:01
@netlify
Copy link

netlify bot commented Dec 4, 2025

Deploy Preview for vite-docs-v7 ready!

Name Link
🔨 Latest commit e64cc9f
🔍 Latest deploy log https://app.netlify.com/projects/vite-docs-v7/deploys/693457d3f5a2f60008dedce7
😎 Deploy Preview https://deploy-preview-21183--vite-docs-v7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bluwy
Copy link
Member

bluwy commented Dec 4, 2025

We can just bump to 0.27.0 as we've done the same in the past. This'll likely be merged shortly after as a small v7 minor.

@GameRoMan
Copy link
Author

Ok, thank you, if there is anything else I need to do or change just tell me

@silverwind
Copy link

silverwind commented Dec 4, 2025

we might want to specify ^0.25.0 || ^0.26.0 || ^0.27.0 or some such thing

No you can not do that anyways because minor v0 versions are considered incompatible to each other.

otherwise projects that can't move off esbuild 0.25.0 yet will end up installing two copies

And I'm in the opposite situation where another project (storybook) installs 0.27 but vite lags behind resulting in the duplicate.

@GameRoMan GameRoMan changed the title chore(deps): update esbuild from 0.25.0 to 0.27.0 chore(deps/v7): update esbuild from 0.25.0 to 0.27.0 Dec 4, 2025
@43081j
Copy link
Contributor

43081j commented Dec 5, 2025

No you can not do that anyways because minor v0 versions are considered incompatible to each other.

Just to be clear, you can do that. Yes, a minor 0.x version is basically a major. But we know these three versions of esbuild are compatible, and that's what the OR is for.

Though I agree with Bjorn now, that we should just bump the version.

@silverwind
Copy link

silverwind commented Dec 5, 2025

Yeah I think ultimately esbuild it to blame that they are still on v0. They do release their changes as breaking but effectively, esbuild changes are rarely actually breaking. So I agree, just keep it at latest minor version.

@GameRoMan GameRoMan force-pushed the chore/v7/update-esbuild branch from 2b39082 to e64cc9f Compare December 6, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants