Skip to content

Escape spaces in paths in directories in the classpath in the generated Manifest file #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tresat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Escape spaces in paths in directories in the classpath in the generated Manifest file #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ build.gradle snippet to use ManifestClasspath plugin
##### Build script snippet for plugins DSL for Gradle 2.1 and later
```
plugins {
id "com.github.ManifestClasspath" version "0.1.0-RELEASE"
id "com.github.ManifestClasspath" version "0.2.0-RELEASE"
}
```
##### Build script snippet for use in older Gradle versions or where dynamic configuration is required
Expand All @@ -26,7 +26,7 @@ buildscript {
}
}
dependencies {
classpath "gradle.plugin.com.github.viswaramamoorthy:gradle-util-plugins:0.1.0-RELEASE"
classpath "gradle.plugin.com.github.viswaramamoorthy:gradle-util-plugins:0.2.0-RELEASE"
}
}

Expand Down
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ apply plugin: 'io.codearte.nexus-staging'
apply plugin: 'com.gradle.plugin-publish'

group = 'com.github.viswaramamoorthy'
version = '0.1.0-RELEASE'
version = '0.2.0-RELEASE'

sourceCompatibility = 1.8

Expand Down
14 changes: 13 additions & 1 deletion src/main/groovy/vr/util/ManifestUtil.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,23 @@ class ManifestUtil
if (!fileCollection)
return
def classPathString = fileCollection.files.collect {
it.toURL().toString()
toClassPathEntry(it)
}.join(' ')
createManifestJar(jarFile, manifestWithClasspath(classPathString))
}

/**
* Convert a file to its URL, with any spaces in the path replaced by {@ %20} so that directories
* containing spaces in their names in the classpath will be properly processed when running.
*
* @param element file to convert to string for inclusion in classpath
* @return classpath string referencing given file, as described
*/
private static String toClassPathEntry(File element) {
String path = element.toURL().toString()
return path.replaceAll(' ', '%20')
}

private static def createManifestJar(def jarFile, def manifest = null) throws IOException {
def jarOutputStream

Expand Down