New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect url building for GET_MANY request type #2

Open

eksd opened this issue Nov 27, 2019 · 0 comments

eksd commented Nov 27, 2019 •

edited

Loading

The source code for GET_MANY url building is the following:

      case GET_MANY: {
        const query = {
          filter: JSON.stringify({ id: params.ids })
        };
        let idStr = "";
        const queryString = params.ids.map(id => idStr + `id=${id}`);
        url = `${apiUrl}/${resource}?${idStr}}`;
        break;
      }

Here we have 3 different mistakes:

variable 'query' is created but never used after.
variable 'queryString' is created but instead of it an empty 'idStr' is used.
redundant bracket ${idStr}};

As a result, GET_MANY url is completely unusable.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment