wip

Author: vincentauger

src/Data/DOIData.php

@@ -93,7 +93,7 @@ public function __construct(
         public int $versionCount,
         public int $versionOfCount,
         public DateTimeImmutable $created,
-        public DateTimeImmutable $registered,
+        public ?DateTimeImmutable $registered,
         public ?string $published,
         public DateTimeImmutable $updated,
         public RelationshipData $relationships,
@@ -204,10 +204,13 @@ public static function fromArray(array $data): self
             $publisherData = PublisherData::fromArray($publisherArray);
         }
 
-        $creators = array_map(
-            fn (array $item): Creator => Creator::fromArray($item),
-            $creatorsData
-        );
+        $creators = array_values(array_filter(
+            array_map(
+                fn (array $item): ?Creator => Creator::fromArray($item),
+                $creatorsData
+            ),
+            fn (?Creator $creator): bool => $creator instanceof \VincentAuger\DataCiteSdk\Data\Metadata\Creator
+        ));
         assert($creators !== [], 'At least one creator is required');
 
         $titles = array_map(
@@ -239,10 +242,13 @@ public static function fromArray(array $data): self
                 fn (array $item): Subject => Subject::fromArray($item),
                 $subjectsData
             ),
-            contributors: array_map(
-                fn (array $item): Contributor => Contributor::fromArray($item),
-                $contributorsData
-            ),
+            contributors: array_values(array_filter(
+                array_map(
+                    fn (array $item): ?Contributor => Contributor::fromArray($item),
+                    $contributorsData
+                ),
+                fn (?Contributor $contributor): bool => $contributor instanceof \VincentAuger\DataCiteSdk\Data\Metadata\Contributor
+            )),
             dates: array_map(
                 fn (array $item): Date => Date::fromArray($item),
                 $datesData
@@ -264,10 +270,13 @@ public static function fromArray(array $data): self
                 fn (array $item): RightsList => RightsList::fromArray($item),
                 $rightsListData
             ),
-            descriptions: array_map(
-                fn (array $item): Description => Description::fromArray($item),
-                $descriptionsData
-            ),
+            descriptions: array_values(array_filter(
+                array_map(
+                    fn (array $item): ?Description => Description::fromArray($item),
+                    $descriptionsData
+                ),
+                fn (?Description $description): bool => $description instanceof \VincentAuger\DataCiteSdk\Data\Metadata\Description
+            )),
             geoLocations: array_map(
                 fn (array $item): GeoLocation => GeoLocation::fromArray($item),
                 $geoLocationsData
@@ -297,7 +306,9 @@ public static function fromArray(array $data): self
             versionCount: (int) $attributes['versionCount'],
             versionOfCount: (int) $attributes['versionOfCount'],
             created: new DateTimeImmutable($attributes['created']),
-            registered: new DateTimeImmutable($attributes['registered']),
+            registered: empty($attributes['registered'])
+                ? null
+                : new DateTimeImmutable($attributes['registered']),
             published: $attributes['published'] ?? null,
             updated: new DateTimeImmutable($attributes['updated']),
             relationships: RelationshipData::fromArray($relationshipsData),

src/Data/Metadata/Contributor.php

@@ -33,13 +33,23 @@ public function __construct(
     ) {}
 
     /**
+     * Create from array, lenient parsing for API responses.
+     * Returns null if required fields are missing (name or contributorType).
+     *
      * @param  array<string, mixed>  $data
      */
-    public static function fromArray(array $data): self
+    public static function fromArray(array $data): ?self
     {
-        assert(is_string($data['name']));
+        // Skip invalid contributors from API responses (legacy/incomplete data)
+        if (! isset($data['name']) || ! is_string($data['name']) || $data['name'] === '') {
+            return null;
+        }
+
+        if (! isset($data['contributorType']) || ! is_string($data['contributorType']) || $data['contributorType'] === '') {
+            return null;
+        }
+
         assert(is_array($data['affiliation']));
-        assert(is_string($data['contributorType']));
         assert(is_array($data['nameIdentifiers']));
 
         /** @var array<array<string, mixed>> $nameIdentifiersData */

src/Data/Metadata/Creator.php

@@ -24,11 +24,18 @@ public function __construct(
     ) {}
 
     /**
+     * Create from array, lenient parsing for API responses.
+     * Returns null if required name field is missing.
+     *
      * @param  array<string, mixed>  $data
      */
-    public static function fromArray(array $data): self
+    public static function fromArray(array $data): ?self
     {
-        assert(is_string($data['name']));
+        // Skip invalid creators from API responses (legacy/incomplete data)
+        if (! isset($data['name']) || ! is_string($data['name']) || $data['name'] === '') {
+            return null;
+        }
+
         assert(is_array($data['affiliation']));
         assert(is_array($data['nameIdentifiers']));
 

src/Data/Metadata/Description.php

@@ -30,12 +30,21 @@ public function __construct(
     ) {}
 
     /**
+     * Create from array, lenient parsing for API responses.
+     * Returns null if required fields are missing (description or descriptionType).
+     *
      * @param  array<string, mixed>  $data
      */
-    public static function fromArray(array $data): self
+    public static function fromArray(array $data): ?self
     {
-        assert(is_string($data['description']));
-        assert(is_string($data['descriptionType']));
+        // Skip invalid descriptions from API responses (legacy/incomplete data)
+        if (! isset($data['description']) || ! is_string($data['description']) || $data['description'] === '') {
+            return null;
+        }
+
+        if (! isset($data['descriptionType']) || ! is_string($data['descriptionType']) || $data['descriptionType'] === '') {
+            return null;
+        }
 
         return new self(
             lang: isset($data['lang']) && is_string($data['lang']) ? $data['lang'] : null,