Skip to content
This repository has been archived by the owner on Sep 12, 2022. It is now read-only.

External plugins don't work #236

Open
orzFly opened this issue Jan 23, 2019 · 1 comment
Open

External plugins don't work #236

orzFly opened this issue Jan 23, 2019 · 1 comment

Comments

@orzFly
Copy link

orzFly commented Jan 23, 2019

I am writing a new plugin and I put it at /Users/USER/Library/Application Support/Harmony/Plugins/node_modules/harmony-USER/index.js. package.json is also presented. The plugin won't load at all.

Root Cause I Think

In loadModules:

> const modulesPaths = ["1"]
undefined
> modulesPaths.concat(["2"])
[ '1', '2' ]
> console.log(modulesPaths)
[ '1' ]
undefined

concat won't modify the array instance. It returns an new Array. This should be why external plugins are not working at all.

@vincelwt
Copy link
Owner

Hi!

Funnily enough someone else reported exactly the same issue just a day before with the same fix.
It'll be good with the next release of Harmony :)

I'm preparing to open-source back the core of Harmony, so this should happen less.
Cheers!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants