Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add visually hidden #24

Closed
phucbm opened this issue May 22, 2023 · 0 comments · Fixed by #26 or #29
Closed

add visually hidden #24

phucbm opened this issue May 22, 2023 · 0 comments · Fixed by #26 or #29
Assignees
@vuquangpham
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@phucbm
Copy link
Member

phucbm commented May 22, 2023

We need this to leverage the support to a11y.

/* Visually hidden */
.visually-hidden {
    position:absolute;overflow:hidden;clip:rect(0 0 0 0);
    width:1px;height:1px;margin:-1px;padding:0; border:0;
}

Read more in this article.
@phucbm phucbm added enhancement New feature or request good first issue Good for newcomers labels May 22, 2023
@vuquangpham vuquangpham mentioned this issue May 29, 2023
Merged
@vuquangpham vuquangpham linked a pull request May 29, 2023 that will close this issue
style(atomic): add visually hidden class #26
Merged
@phucbm phucbm closed this as completed May 30, 2023
@vuquangpham vuquangpham mentioned this issue May 31, 2023
Merged
@vuquangpham vuquangpham linked a pull request May 31, 2023 that will close this issue
1.1.10 #29
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vuquangpham vuquangpham

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(atomic): add visually hidden class viivue/atomic-css
1.1.10 viivue/atomic-css
2 participants
@phucbm @vuquangpham