Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS issue: skeleton-shine unsupported background-position property on PageSpeed #19

Closed
vuquangpham opened this issue Apr 4, 2023 · 1 comment · Fixed by #20
Closed

CSS issue: skeleton-shine unsupported background-position property on PageSpeed #19

vuquangpham opened this issue Apr 4, 2023 · 1 comment · Fixed by #20
Assignees
@phucbm @vuquangpham
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@vuquangpham
Copy link
Contributor

vuquangpham commented Apr 4, 2023 •
edited
Loading

The problem occurs when we test the page speed on https://pagespeed.web.dev/

I think it causes a bug because of the conflict between using background-position in animation.

image
@vuquangpham vuquangpham added the bug Something isn't working label Apr 4, 2023
@phucbm phucbm added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Apr 18, 2023
@vuquangpham vuquangpham changed the title Skeleton bg > Unsupported CSS Properties on PageSpeed CSS issue: skeleton-shine unsupported background-position property on PageSpeed Apr 18, 2023
@vuquangpham vuquangpham linked a pull request Apr 18, 2023 that will close this issue
Skeleton-bg > change animation by using SVGToBase64 #20
Merged
@vuquangpham vuquangpham mentioned this issue Apr 18, 2023
Merged
@phucbm
Copy link
Member

phucbm commented May 8, 2023 •
edited
Loading

Fixed with https://github.com/viivue/atomic-css/releases/tag/v1.1.8

@phucbm phucbm closed this as completed May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phucbm phucbm

@vuquangpham vuquangpham

Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skeleton-bg > change animation by using SVGToBase64 viivue/atomic-css
2 participants
@phucbm @vuquangpham