Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve search UX #6

Closed
daomapsieucap opened this issue Dec 9, 2021 · 2 comments
Closed

Improve search UX #6

daomapsieucap opened this issue Dec 9, 2021 · 2 comments
Assignees
@phucbm
Labels
enhancement New feature or request nice to have

Comments

@daomapsieucap
Copy link
Member

I think it would be nice if

  • We have some messages for the case that no items were found after searching 👀.
  • There are some loading icons 💨 when searching, so users can know that they are doing the search task.
@daomapsieucap daomapsieucap added the enhancement New feature or request label Dec 9, 2021
@phucbm
Copy link
Member

phucbm commented Dec 9, 2021

You're right about the "no item found" message, will do.
I also thought about the loading icon but the waiting time is pretty short actually, but I agree that it does look better with the loading icon. Maybe I'll add some more delay so we will have more time to enjoy it 😆

@phucbm
Copy link
Member

phucbm commented Apr 15, 2022

Done with ACF Icomoon v4.0

@phucbm phucbm closed this as completed Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phucbm phucbm

Labels
enhancement New feature or request nice to have
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phucbm @daomapsieucap