-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjusted path to selection.json not working #12
Comments
Hi @silversession, Could you help us provide some more information to debug the issue:
Just because I've tested to update selection.json on my site but it's still working, I think there is some wrong config which I would like to know exactly to fix the issue. Thanks for supporting our plugin. |
Hi @daomapsieucap,
In the acf-field there is the option to adjust the path to the json-file. It seems, that the path to the json-File is hard Coded. If I put the json file in assets/fonts/selection.json everything works fine - even if the path to the json file is different than the json location. If I move the the file to assets/fonts/icomoon/selection.json and adjust the path in the acf-field as well - then the icons are not found. File under assets/fonts/icomoon/selection.json Empty selection in Gutenberg Editor Path to assets/fonts/icomoon/selection.json If I move the file to assets/fonts/selection.json - then it works out of the box. Even if the path in the acf field is wrong/different... Hope that helps? |
Hi @silversession, Sorry for the late reply, I tested and found the bug. The latest version fixed this issue, but there is some issue when releasing the plugin to wordpress.org. Please try to download and install v4.0.8 here: https://github.com/viivue/acf-icomoon/releases/tag/v4.0.8. Thanks for taking time help us to figure out the bug. |
I just tested it. It works! |
Trying to adjust the path in the acf field to
assets/fonts/icomoon/selection.json
ordist/fonts/icomoon/selection.json
will result in an empty overlay (where you can actually select the icons).The text was updated successfully, but these errors were encountered: