Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted path to selection.json not working #12

Closed
silversession opened this issue Aug 5, 2022 · 4 comments
Closed

Adjusted path to selection.json not working #12

silversession opened this issue Aug 5, 2022 · 4 comments
Assignees
Labels
good first issue Good for newcomers question Further information is requested

Comments

@silversession
Copy link

silversession commented Aug 5, 2022

Trying to adjust the path in the acf field to assets/fonts/icomoon/selection.json or dist/fonts/icomoon/selection.json will result in an empty overlay (where you can actually select the icons).

@phucbm phucbm assigned daomapsieucap and phucbm and unassigned phucbm Aug 19, 2022
@phucbm phucbm added the good first issue Good for newcomers label Aug 19, 2022
@daomapsieucap
Copy link
Member

Hi @silversession,

Could you help us provide some more information to debug the issue:

  • Some screenshots about the case you've got.
  • Which plugin version you've installed (could you try to update to the latest version of our plugin?)
  • Some more description about the specific steps to reproduce the issue?

Just because I've tested to update selection.json on my site but it's still working, I think there is some wrong config which I would like to know exactly to fix the issue.

Thanks for supporting our plugin.

@daomapsieucap daomapsieucap added the question Further information is requested label Aug 23, 2022
@silversession
Copy link
Author

silversession commented Sep 30, 2022

Hi @daomapsieucap,

  • I use the newest Version of the Plugin: 4.0.7

In the acf-field there is the option to adjust the path to the json-file. It seems, that the path to the json-File is hard Coded.

If I put the json file in assets/fonts/selection.json everything works fine - even if the path to the json file is different than the json location. If I move the the file to assets/fonts/icomoon/selection.json and adjust the path in the acf-field as well - then the icons are not found.

File under assets/fonts/icomoon/selection.json
Bildschirmfoto 2022-09-30 um 11 52 32

Empty selection in Gutenberg Editor
Bildschirmfoto 2022-09-30 um 11 52 21

Path to assets/fonts/icomoon/selection.json
Bildschirmfoto 2022-09-30 um 11 51 45

If I move the file to assets/fonts/selection.json - then it works out of the box. Even if the path in the acf field is wrong/different...

Hope that helps?

@daomapsieucap
Copy link
Member

Hi @silversession,

Sorry for the late reply, I tested and found the bug. The latest version fixed this issue, but there is some issue when releasing the plugin to wordpress.org.

Please try to download and install v4.0.8 here: https://github.com/viivue/acf-icomoon/releases/tag/v4.0.8.

Thanks for taking time help us to figure out the bug.

@silversession
Copy link
Author

I just tested it.

It works!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants