update: prefer mirror manifest with github fallback

Author: vigo999

README.md

@@ -18,7 +18,7 @@ MSCODE_INSTALL_SOURCE=github curl -fsSL https://raw.githubusercontent.com/vigo99
 MSCODE_INSTALL_SOURCE=mirror curl -fsSL https://raw.githubusercontent.com/vigo999/mindspore-code/main/scripts/install.sh | bash
 
 # Override the mirror base URL if you host your own Caddy/Nginx mirror.
-MSCODE_MIRROR_BASE_URL=http://13.229.44.116/mscode/releases curl -fsSL https://raw.githubusercontent.com/vigo999/mindspore-code/main/scripts/install.sh | bash
+MSCODE_MIRROR_BASE_URL=http://47.115.175.134/mscode/releases curl -fsSL https://raw.githubusercontent.com/vigo999/mindspore-code/main/scripts/install.sh | bash
 ```
 
 ### Build from source

internal/update/checker.go

@@ -43,17 +43,38 @@ func Check(ctx context.Context, currentVersion string) (*CheckResult, error) {
 }
 
 func fetchManifest(ctx context.Context) (*Manifest, error) {
+	return fetchManifestFromURLs(ctx, ManifestURLs())
+}
+
+func fetchManifestFromURLs(ctx context.Context, urls []string) (*Manifest, error) {
+	if len(urls) == 0 {
+		return nil, fmt.Errorf("no manifest URLs configured")
+	}
+
+	var errs []string
+	for _, url := range urls {
+		m, err := fetchManifestFromURL(ctx, url)
+		if err == nil {
+			return m, nil
+		}
+		errs = append(errs, fmt.Sprintf("%s: %v", url, err))
+	}
+
+	return nil, fmt.Errorf("fetch manifest: %s", strings.Join(errs, "; "))
+}
+
+func fetchManifestFromURL(ctx context.Context, url string) (*Manifest, error) {
 	ctx, cancel := context.WithTimeout(ctx, 5*time.Second)
 	defer cancel()
 
-	req, err := http.NewRequestWithContext(ctx, http.MethodGet, ManifestURL(), nil)
+	req, err := http.NewRequestWithContext(ctx, http.MethodGet, url, nil)
 	if err != nil {
 		return nil, fmt.Errorf("create request: %w", err)
 	}
 
 	resp, err := http.DefaultClient.Do(req)
 	if err != nil {
-		return nil, fmt.Errorf("fetch manifest: %w", err)
+		return nil, err
 	}
 	defer resp.Body.Close()
 

internal/update/checker_test.go

@@ -0,0 +1,57 @@
+package update
+
+import (
+	"context"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+)
+
+func TestManifestURLsDefaultOrder(t *testing.T) {
+	t.Setenv("MSCODE_MANIFEST_URL", "")
+
+	got := ManifestURLs()
+	if len(got) != 2 {
+		t.Fatalf("ManifestURLs() len = %d, want 2", len(got))
+	}
+	if got[0] != defaultMirrorManifestURL {
+		t.Fatalf("ManifestURLs()[0] = %q, want %q", got[0], defaultMirrorManifestURL)
+	}
+	if got[1] != defaultGitHubManifestURL {
+		t.Fatalf("ManifestURLs()[1] = %q, want %q", got[1], defaultGitHubManifestURL)
+	}
+}
+
+func TestManifestURLsEnvOverride(t *testing.T) {
+	t.Setenv("MSCODE_MANIFEST_URL", "http://example.test/manifest.json")
+
+	got := ManifestURLs()
+	if len(got) != 1 {
+		t.Fatalf("ManifestURLs() len = %d, want 1", len(got))
+	}
+	if got[0] != "http://example.test/manifest.json" {
+		t.Fatalf("ManifestURLs()[0] = %q, want env override", got[0])
+	}
+}
+
+func TestFetchManifestFallsBackToNextURL(t *testing.T) {
+	success := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		w.Header().Set("Content-Type", "application/json")
+		_, _ = w.Write([]byte(`{"latest":"0.5.0-beta.2","min_allowed":"","download_base":"http://mirror.example/mscode/releases"}`))
+	}))
+	defer success.Close()
+
+	got, err := fetchManifestFromURLs(context.Background(), []string{
+		"http://127.0.0.1:1/latest/manifest.json",
+		success.URL,
+	})
+	if err != nil {
+		t.Fatalf("fetchManifestFromURLs() error = %v", err)
+	}
+	if got.Latest != "0.5.0-beta.2" {
+		t.Fatalf("manifest latest = %q, want %q", got.Latest, "0.5.0-beta.2")
+	}
+	if got.DownloadBase != "http://mirror.example/mscode/releases" {
+		t.Fatalf("manifest download_base = %q", got.DownloadBase)
+	}
+}

internal/update/paths.go

@@ -6,7 +6,10 @@ import (
 	"runtime"
 )
 
-const defaultManifestURL = "https://github.com/vigo999/mindspore-code/releases/latest/download/manifest.json"
+const (
+	defaultMirrorManifestURL = "http://47.115.175.134/mscode/releases/latest/manifest.json"
+	defaultGitHubManifestURL = "https://github.com/vigo999/mindspore-code/releases/latest/download/manifest.json"
+)
 
 // InstallDir returns ~/.mscode/bin.
 func InstallDir() string {
@@ -28,10 +31,20 @@ func ConfigDir() string {
 	return filepath.Join(home, ".mscode")
 }
 
-// ManifestURL returns the manifest URL, overridable via MSCODE_MANIFEST_URL.
+// ManifestURL returns the first manifest URL candidate.
 func ManifestURL() string {
+	urls := ManifestURLs()
+	if len(urls) == 0 {
+		return ""
+	}
+	return urls[0]
+}
+
+// ManifestURLs returns manifest URL candidates in lookup order.
+// If MSCODE_MANIFEST_URL is set, it is used exclusively.
+func ManifestURLs() []string {
 	if u := os.Getenv("MSCODE_MANIFEST_URL"); u != "" {
-		return u
+		return []string{u}
 	}
-	return defaultManifestURL
+	return []string{defaultMirrorManifestURL, defaultGitHubManifestURL}
 }

scripts/install.sh

@@ -2,7 +2,7 @@
 set -euo pipefail
 
 GITHUB_REPO="${MSCODE_GITHUB_REPO:-vigo999/mindspore-code}"
-MIRROR_BASE_URL="${MSCODE_MIRROR_BASE_URL:-http://13.229.44.116/mscode/releases}"
+MIRROR_BASE_URL="${MSCODE_MIRROR_BASE_URL:-http://47.115.175.134/mscode/releases}"
 INSTALL_DIR="$HOME/.mscode/bin"
 BINARY_NAME="mscode"
 INSTALL_SOURCE="${MSCODE_INSTALL_SOURCE:-auto}"