Skip to content
This repository was archived by the owner on Oct 14, 2024. It is now read-only.

Commit 49b2835

Browse files
author
Miller
committed
https://github.com/victos/angular-opensource/issues/16
1 parent db76223 commit 49b2835

File tree

7 files changed

+38
-33
lines changed

7 files changed

+38
-33
lines changed

package.json

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -12,43 +12,43 @@
1212
"private": true,
1313
"dependencies": {
1414
"@angular/animations": "^8.0.0",
15-
"@angular/cdk": "^7.2.0",
15+
"@angular/cdk": "^8.0.0",
1616
"@angular/common": "^8.0.0",
1717
"@angular/compiler": "^8.0.0",
1818
"@angular/core": "^8.0.0",
1919
"@angular/forms": "^8.0.0",
20-
"@angular/material": "^7.2.0",
20+
"@angular/material": "^8.0.0",
2121
"@angular/platform-browser": "^8.0.0",
2222
"@angular/platform-browser-dynamic": "^8.0.0",
2323
"@angular/router": "^8.0.0",
2424
"code-prettify": "^0.1.0",
25-
"core-js": "^2.5.4",
25+
"core-js": "^3.1.3",
2626
"rxjs": "6.5.2",
2727
"zone.js": "~0.9.1"
2828
},
2929
"devDependencies": {
3030
"@angular/compiler-cli": "^8.0.0",
3131
"@angular-devkit/build-ng-packagr": "~0.800.0",
3232
"@angular-devkit/build-angular": "~0.800.0",
33-
"ng-packagr": "^3.0.0-rc.2",
34-
"tsickle": ">=0.25.5",
33+
"ng-packagr": "^5.2.0",
34+
"tsickle": "0.35.0",
3535
"tslib": "^1.9.0",
3636
"typescript": "~3.4.5",
3737
"@angular/cli": "8.0.1",
3838
"@angular/language-service": "^8.0.0",
39-
"@types/jasmine": "~2.8.6",
40-
"@types/jasminewd2": "~2.0.3",
41-
"@types/node": "~8.9.4",
39+
"@types/jasmine": "~3.3.13",
40+
"@types/jasminewd2": "~2.0.6",
41+
"@types/node": "~12.0.4",
4242
"codelyzer": "^5.0.1",
43-
"jasmine-core": "~2.99.1",
43+
"jasmine-core": "~3.4.0",
4444
"jasmine-spec-reporter": "~4.2.1",
45-
"karma": "~1.7.1",
45+
"karma": "~4.1.0",
4646
"karma-chrome-launcher": "~2.2.0",
47-
"karma-coverage-istanbul-reporter": "~1.4.2",
48-
"karma-jasmine": "~1.1.1",
49-
"karma-jasmine-html-reporter": "^0.2.2",
50-
"protractor": "~5.3.0",
51-
"ts-node": "~5.0.1",
52-
"tslint": "~5.9.1"
47+
"karma-coverage-istanbul-reporter": "~2.0.5",
48+
"karma-jasmine": "~2.0.1",
49+
"karma-jasmine-html-reporter": "^1.4.2",
50+
"protractor": "~5.4.2",
51+
"ts-node": "~8.2.0",
52+
"tslint": "~5.17.0"
5353
}
54-
}
54+
}

projects/ng-busy/README.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@
44

55
6.x version is used for angular 6.x
66

7+
7.x version is used for angular 7.x
8+
9+
8.x version is used for angular 8.x
10+
711
**NgBusy** can show busy/loading indicators on any promise, or on any Observable's subscription.
812

913
[![Travis](https://img.shields.io/travis/victos/angular-opensource/master.svg?label=Travis%20CI&style=flat-square)](https://travis-ci.org/victos/angular-opensource)

projects/ng-busy/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ng-busy",
3-
"version": "7.0.0",
3+
"version": "8.0.0",
44
"description": "Show busy/loading indicators on any promise or subscription",
55
"author": "victos",
66
"license": "MIT",
@@ -35,9 +35,9 @@
3535
"npm": ">= 5.6.0"
3636
},
3737
"peerDependencies": {
38-
"@angular/common": "^7.0.0-rc.0 || ^7.0.0",
39-
"@angular/core": "^7.0.0-rc.0 || ^7.0.0",
40-
"@angular/animations": "^7.0.0-rc.0 || ^7.0.0",
38+
"@angular/common": "^8.0.0",
39+
"@angular/core": "^8.0.0",
40+
"@angular/animations": "^8.0.0",
4141
"rxjs": "^6.0.0"
4242
}
4343
}

projects/ng-busy/src/lib/ng-busy.directive.spec.ts

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,20 @@ const createSubscriptionWithDelay = (delay: number): Subscription => {
3434
o.next();
3535
o.complete();
3636
}, delay);
37-
}).subscribe(() => {});
37+
}).subscribe(() => {
38+
});
3839
};
3940

4041
// @ts-ignore
4142
@Component({
4243
selector: 'lib-component-template',
4344
template: `
44-
<div>
45-
<div>
46-
{{message}}
47-
</div>
48-
</div>
49-
`,
45+
<div>
46+
<div>
47+
{{message}}
48+
</div>
49+
</div>
50+
`,
5051
})
5152
export class CustomBusyComponent {
5253

@@ -67,7 +68,7 @@ export class CustomBusyComponent {
6768
})
6869
class TestNgBusyComponent {
6970
options: any;
70-
@ViewChild('customTemplate', /* TODO: add static flag */ {})
71+
@ViewChild('customTemplate', {static: true})
7172
customTemplate: TemplateRef<any>;
7273
}
7374

@@ -78,7 +79,9 @@ class TestNgBusyComponent {
7879
})
7980
class TestNgBusyOnPushComponent {
8081
options: any;
81-
constructor(public cdr: ChangeDetectorRef) {}
82+
83+
constructor(public cdr: ChangeDetectorRef) {
84+
}
8285
}
8386

8487
describe('NgBusyDirective', () => {

projects/ng-busy/src/lib/ng-busy.directive.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@ import {
88
Output,
99
Renderer2,
1010
TemplateRef, Type,
11-
ViewContainerRef
11+
ViewContainerRef, ViewRef
1212
} from '@angular/core';
13-
import { ViewRef } from '@angular/core/src/linker/view_ref';
1413
import { BusyTrackerService } from './service/busy-tracker.service';
1514
import { BusyConfigHolderService } from './service/busy-config-holder.service';
1615
import { Subscription } from 'rxjs';

projects/ng-busy/src/test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// This file is required by karma.conf.js and loads recursively all the .spec and framework files
22

3-
import 'core-js/es7/reflect';
43
import 'zone.js/dist/zone';
54
import 'zone.js/dist/zone-testing';
65
import { getTestBed } from '@angular/core/testing';

styles.css

Whitespace-only changes.

0 commit comments

Comments
 (0)