Skip to content

[APP-10023] Update joint positions when pose changes and vice versa #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+385 −479
Open

[APP-10023] Update joint positions when pose changes and vice versa #445

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
474a328
add joint positions widget
martha-johnston Oct 29, 2025
a60ae2e
arm_new generic screen
martha-johnston Oct 29, 2025
6e38c07
Change label from 'Joint Angles' to 'Joint Positions'
martha-johnston Oct 29, 2025
3d0d5a9
Implement joint position functionality (#441)
martha-johnston Oct 30, 2025
7c5540d
use theme for colors
martha-johnston Oct 30, 2025
8b0b6d9
Merge branch 'main' into app-9878/joint-positions
martha-johnston Oct 31, 2025
a3a68c1
update joint angle limits
martha-johnston Oct 31, 2025
ea583bc
update arm values
martha-johnston Nov 3, 2025
6d78cd3
Merge branch 'main' into app-10023/update
martha-johnston Nov 7, 2025
4a082e2
update branch
martha-johnston Nov 7, 2025
7a432db
switch arm_new to arm
martha-johnston Nov 7, 2025
9d42291
extend sliders (#449)
martha-johnston Nov 7, 2025
8bf470a
pr comments
martha-johnston Nov 7, 2025
1dd39cd
remove new suffix
martha-johnston Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/widgets/resources/arm_widgets/joint_positions_widget.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ class _BuildJointControlRow extends StatefulWidget {
}

class _BuildJointControlRowState extends State<_BuildJointControlRow> {
static const double _minPosition = 0.0;
static const double _maxPosition = 180.0;
static const double _minPosition = -359.0;
static const double _maxPosition = 359.0;

List<double> _jointValues = [];
Copy link
Member

@tgritter tgritter Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have two copies of _jointValues, one in the RowState and another in the parent widget. It might be better just to have one list you are manipulating for clarity. Even if you do need the original list, you could only pass the values you need into the row like so: startJointValues: _jointValues[index]

List<TextEditingController> _textControllers = [];
Expand Down