Skip to content

Conversation

@allisonschiang
Copy link

@allisonschiang allisonschiang commented Nov 10, 2025

As part of a project to improve error logging, I want to link the error: "Failed to connect to robot within time limit. Check network connection and try again. See http://docs.viam.com/dev/tools/common-errors/#conn-time-out" for troubleshooting steps" to some networking steps for debugging. Because the steps are already on the docs, I'm just moving the steps into their own section and then linking both the existing error and my new error to that networking section

The git changes looks really weird because im moving the network debugging text to just after the "Unable to create PeerConnection with module" so it shows me deleting it and re-adding it after but my changes have nothing to do with peerconnection stuff

Changes include adding a "failed to connect to robot" section, creating a network debugging section, and linking the "failed to connect to robot" and "Connection establishment failed" to this section

in conjunction with RDK log improvement: viamrobotics/rdk#5466

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 10, 2025
@netlify
Copy link

netlify bot commented Nov 10, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit ab2cc89
🔍 Latest deploy log https://app.netlify.com/projects/viam-docs/deploys/6913acbed5ff3f0008d125fc
😎 Deploy Preview https://deploy-preview-4742--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 58 (🟢 up 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@allisonschiang allisonschiang marked this pull request as ready for review November 11, 2025 16:22
@npentrel
Copy link
Collaborator

@allisonschiang is this good to merge?

@allisonschiang
Copy link
Author

allisonschiang commented Nov 12, 2025

@allisonschiang is this good to merge?

@npentrel the "failed to connect to robot within time limit" log is new with another PR I have up right now so I wanted to merge both at the same time! Not a big deal but in case the exact wording of the log gets changed in review I wanted to update it here too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to build This pull request is marked safe to build from a trusted zone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants