Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Windows Platform support #125

Closed
yoshiask opened this issue Jun 3, 2020 · 6 comments
Closed

Universal Windows Platform support #125

yoshiask opened this issue Jun 3, 2020 · 6 comments
Labels
Resolution/Merged into another issue This issue has been merged into another issue. Type/Platform

Comments

@yoshiask
Copy link

yoshiask commented Jun 3, 2020

What is this platform?
The primary platform for modern Windows apps, which can run on all Windows 10 devices.

Why should it be supported?
Some developers don't want to deal with cross-platform frameworks like Uno or Xamarin.Forms. It would also allow easier porting of WPF (and to a lesser extent, WinForms) apps.

Why should it not be supported?
UWP is already available using Xamarin.Forms, and #121 would support it via the Uno Platform.

Additional context
I personally want to use this in my UWP project, and while it's already pretty easy, rendering to an SKCanvas manually doesn't have the advantages of being its own XAML control. For example, databinding isn't possible when rendering using a MathPainter in the code behind.

@yoshiask yoshiask added Status/0. New This issue is new and is awaiting confirmation from the maintainers. Type/Platform labels Jun 3, 2020
@Happypig375
Copy link
Collaborator

Platform Uno will not be referenced when used in a UWP project.
https://github.com/verybadcat/CSharpMath/pull/121/files#diff-804e77684648c08794add964c24dabd1R12

@Happypig375 Happypig375 added Status/½. Needs more information Information needs to be provided for this issue to continue. and removed Status/0. New This issue is new and is awaiting confirmation from the maintainers. labels Jun 3, 2020
@Happypig375
Copy link
Collaborator

As this will be supported via #121, this should be part of #120.

@yoshiask
Copy link
Author

yoshiask commented Jun 3, 2020

What do you mean by "part of"? As it stands, anyone who wants to use the CSharpMath XAML controls in a UWP project (not Uno) would have to reference the Uno Platform. I guess that's technically fine, but it's really weird.

@Happypig375
Copy link
Collaborator

CSharpMath.Uno will not reference Platform Uno when used on UWP. Read this csproj.
https://github.com/verybadcat/CSharpMath/pull/121/files#diff-804e77684648c08794add964c24dabd1R12

@yoshiask
Copy link
Author

yoshiask commented Jun 3, 2020

Oh, I get it now, sorry. So is there no point to having CSharpMath.UWP specifically, or should everyone on UWP use CSharpMath.Uno?

@Happypig375
Copy link
Collaborator

Platform Uno is supposed to be "UWP everywhere", so it makes sense that UWP is natively supported. Everyone on pure UWP should use CSharpMath.Uno. A rename from CSharpMath.Uno to CSharpMath.UWPUno may better signify this. This issue is now merged into #120.

@Happypig375 Happypig375 added Resolution/Merged into another issue This issue has been merged into another issue. and removed Status/½. Needs more information Information needs to be provided for this issue to continue. labels Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution/Merged into another issue This issue has been merged into another issue. Type/Platform
Projects
None yet
Development

No branches or pull requests

2 participants