clippy and hanging_detection fixes

Author: sokra

turbopack/crates/turbo-tasks-backend/src/backend/operation/aggregation_update.rs

@@ -2490,12 +2490,10 @@ impl AggregationUpdateQueue {
                 TaskDataCategory::Meta
             },
         );
-        if let Some(task_type) = task_type {
-            if !task.has_key(&CachedDataItemKey::TaskType {}) {
-                let _ = task.add_new(CachedDataItem::TaskType {
-                    value: Arc::from(task_type),
-                });
-            }
+        if let Some(task_type) = task_type
+            && !task.has_key(&CachedDataItemKey::TaskType {})
+        {
+            task.add_new(CachedDataItem::TaskType { value: task_type });
         }
         let state = get_mut_or_insert_with!(task, Activeness, || ActivenessState::new(task_id));
         let is_new = state.is_empty();

turbopack/crates/turbo-tasks-backend/src/utils/dash_map_raw_entry.rs

@@ -1,5 +1,5 @@
 use std::{
-    hash::{BuildHasher, Hash, Hasher},
+    hash::{BuildHasher, Hash},
     ops::{Deref, DerefMut},
 };
 
@@ -17,11 +17,7 @@ pub fn raw_entry<'l, K: Eq + Hash + AsRef<Q>, V, Q: Eq + Hash, S: BuildHasher +
     let result = shard.find_or_find_insert_slot(
         hash,
         |(k, _v)| k.as_ref() == key,
-        |(k, _v)| {
-            let mut hasher = hasher.build_hasher();
-            k.hash(&mut hasher);
-            hasher.finish()
-        },
+        |(k, _v)| hasher.hash_one(k),
     );
     match result {
         Ok(bucket) => RawEntry::Occupied(OccupiedEntry { bucket, shard }),

turbopack/crates/turbo-tasks/src/event.rs

@@ -16,7 +16,7 @@ use tokio::time::{Timeout, timeout};
 
 pub trait EventDescriptor {
     #[cfg(feature = "hanging_detection")]
-    fn get_description(&self) -> Arc<dyn Fn() -> String + Sync + Send>;
+    fn get_description(self) -> Arc<dyn Fn() -> String + Sync + Send>;
 }
 
 impl<T, InnerFn> EventDescriptor for T
@@ -25,8 +25,8 @@ where
     InnerFn: Fn() -> String + Sync + Send + 'static,
 {
     #[cfg(feature = "hanging_detection")]
-    fn get_description(&self) -> Arc<dyn Fn() -> String + Sync + Send> {
-        (self)()
+    fn get_description(self) -> Arc<dyn Fn() -> String + Sync + Send> {
+        Arc::new((self)())
     }
 }
 
@@ -38,14 +38,14 @@ pub struct EventDescription {
 
 impl EventDescription {
     #[inline(always)]
-    pub fn new<InnerFn>(_description: impl FnOnce() -> InnerFn) -> Self
+    pub fn new<InnerFn>(#[allow(unused_variables)] description: impl FnOnce() -> InnerFn) -> Self
     where
         InnerFn: Fn() -> String + Sync + Send + 'static,
     {
-        return Self {
+        Self {
             #[cfg(feature = "hanging_detection")]
             description: Arc::new((description)()),
-        };
+        }
     }
 }
 
@@ -61,8 +61,8 @@ impl Display for EventDescription {
 
 impl EventDescriptor for EventDescription {
     #[cfg(feature = "hanging_detection")]
-    fn get_description(&self) -> Arc<dyn Fn() -> String + Sync + Send> {
-        self.description.clone()
+    fn get_description(self) -> Arc<dyn Fn() -> String + Sync + Send> {
+        self.description
     }
 }
 
@@ -87,14 +87,14 @@ impl Event {
     /// The outer closure allows avoiding extra lookups (e.g. task type info) that may be needed to
     /// capture information needed for constructing (moving into) the inner closure.
     #[inline(always)]
-    pub fn new(_description: impl EventDescriptor) -> Self {
+    pub fn new(#[allow(unused_variables)] description: impl EventDescriptor) -> Self {
         #[cfg(not(feature = "hanging_detection"))]
         return Self {
             event: event_listener::Event::new(),
         };
         #[cfg(feature = "hanging_detection")]
         return Self {
-            description: _description.get_description(),
+            description: description.get_description(),
             event: event_listener::Event::new(),
         };
     }