Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAN bus set min/max wattage limits #95

Open
Stefan-Code opened this issue May 26, 2019 · 1 comment
Open

CAN bus set min/max wattage limits #95

Stefan-Code opened this issue May 26, 2019 · 1 comment

Comments

@Stefan-Code
Copy link

As far as I understand #63 there should be some way to set the minimum and maximum wattage over the CAN bus interface

The good news with this update is that other new commands are coming to enable profile support, namely COMM_SET_MCCONF_TEMP and COMM_SET_MCCONF_TEMP_SETUP, where a short configuration with only current, power, erpm (or m/s) and duty limits can be sent. The setup command allows using m/s and can also be applied to all VESCs on the CAN-bus if a flag is set.

However, I am unable to find this functionality in comm_can.c. Am I missing something or is this functionality not implemented?
If that is the case, can we add
CAN_PACKET_CONF_POWER_LIMITS
CAN_PACKET_CONF_STORE_POWER_LIMITS
to the CAN bus interface?

I would be willing to try to put a pull request for this together if needed.

Also, are there any plans to extend the UAVCAN interface so it provides the same functionality as the "normal" CAN interface?

@vedderb
Copy link
Owner

vedderb commented Sep 6, 2019

This functionality is implemented over the regular commands interface, which also can be accessed over the CAN commands with the fill_rx_buffer and process_rx_buffer commands. That is a bit trickier though than the simple can commands. I can look into adding simple can commands for it, it should be quite easy.

I don't have any device that uses UAVCAN at the moment, so it only supports some basic functionality that is relatively untested. I will probably look into it more at some point though as many people seem interested in UAVCAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants