chore(ci): simplify diagnostics with run_diag helper

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: pront

.github/workflows/k8s_e2e.yml

@@ -212,43 +212,28 @@ jobs:
       - name: Collect K8s diagnostics on failure
         if: failure()
         run: |
-          echo "=== Namespaces ==="
-          kubectl get namespaces 2>&1 || true
+          # Best-effort diagnostics — never fail the job
+          run_diag() { echo "--- $1 ---"; eval "$2" 2>&1 || true; echo; }
 
-          for ns in $(kubectl get namespaces -o jsonpath='{.items[*].metadata.name}' | tr ' ' '\n' | grep -E '^vector-'); do
-            echo ""
+          run_diag "Namespaces" "kubectl get namespaces"
+
+          for ns in $(kubectl get namespaces -o jsonpath='{.items[*].metadata.name}' 2>/dev/null | tr ' ' '\n' | grep -E '^vector-'); do
             echo "=========================================="
             echo "=== Namespace: $ns ==="
             echo "=========================================="
+            run_diag "Pods"             "kubectl get pods -n $ns -o wide"
+            run_diag "Pod descriptions" "kubectl describe pods -n $ns"
+            run_diag "Events"           "kubectl get events -n $ns --sort-by=.lastTimestamp"
+            run_diag "ConfigMaps"       "kubectl get configmaps -n $ns -o yaml"
 
-            echo "--- Pods ---"
-            kubectl get pods -n "$ns" -o wide 2>&1 || true
-
-            echo "--- Pod descriptions ---"
-            kubectl describe pods -n "$ns" 2>&1 || true
-
-            echo "--- Container logs ---"
             for pod in $(kubectl get pods -n "$ns" -o jsonpath='{.items[*].metadata.name}' 2>/dev/null); do
-              echo "--- Logs: $pod ---"
-              kubectl logs -n "$ns" "$pod" --tail=100 2>&1 || true
-              echo "--- Previous logs: $pod ---"
-              kubectl logs -n "$ns" "$pod" --previous --tail=50 2>&1 || true
+              run_diag "Logs: $pod"          "kubectl logs -n $ns $pod --tail=100"
+              run_diag "Previous logs: $pod" "kubectl logs -n $ns $pod --previous --tail=50"
             done
-
-            echo "--- Events ---"
-            kubectl get events -n "$ns" --sort-by=.lastTimestamp 2>&1 || true
-
-            echo "--- ConfigMaps ---"
-            kubectl get configmaps -n "$ns" -o yaml 2>&1 || true
           done
 
-          echo ""
-          echo "=== Node resources ==="
-          kubectl describe nodes 2>&1 | grep -A20 "Allocated resources" || true
-
-          echo ""
-          echo "=== Minikube logs (last 100 lines) ==="
-          minikube logs --length=100 2>&1 || true
+          run_diag "Node resources"  "kubectl describe nodes | grep -A20 'Allocated resources'"
+          run_diag "Minikube logs"   "minikube logs --length=100"
 
   final-result:
     name: K8s E2E Suite