Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming Components in Gum should be less fragile, lower friction #1677

Closed
profexorgeek opened this issue Jan 24, 2025 · 2 comments
Closed
Assignees
Labels

Comments

@profexorgeek
Copy link
Collaborator

Create an object in a Gum folder such as Components/Elements/MyNewThing.

Attempt to rename it, especially while Glue is running.

Expected behavior: the object is renamed and new code files are created. The old code files are removed from the project but not deleted.

Actual behavior: Gum may change the component's folder and put it at root. Attempting to drag the component into a folder produces errors. Glue spams the project with extra files that aren't wanted or expected in a rename due to path failures.

There have been so many errors related to component paths, slash direction, and similar things in Gum that it probably merits some extra dev testing and prodding to test common scenarios as part of this task. At a minimum, testing renaming and moving components should happen to ensure these processes don't fail in either Gum or Glue's response to the changes.

@profexorgeek
Copy link
Collaborator Author

In the TerraScriber repo, if you pull the commit below and try to rename "RGBSliders" to "RGBChooser" it should repro this issue. Do it with Glue running.

25805833a8d2a929df822378b030ee3d2004075c

Note that I'm on the "dropdown-layer-fix" branch of Gum which is 8 days old as of this comment.

@vchelaru
Copy link
Owner

I believe this has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants