Revise some attributes (#207)

* Revise the drag attribute

* Mark older deprecations as unavailable

* Revise the edit attribute

* Revise the spellcheck attribute

* Revise the translate attribute

* Make the label attribute localizable

* Revise the open attribute

* Revise the headers attribute

* Mark older deprecations as unavailable

* Fix failing test

* Consolidate fill attributes

* Revise the enterkey attribute

* Consolidate popovertarget attributes

* Consolidate shape attributes

* Consolidate stroke attributes

* Tidy up a bit

Author: mattesmohr

Sources/HTMLKit/Abstraction/Attributes/BasicAttributes.swift

@@ -3,7 +3,7 @@ import OrderedCollections
 
 /// The alias combines the global attributes of the basic attributes.
 @_documentation(visibility: internal)
-public typealias GlobalAttributes = AccessKeyAttribute & AutocapitalizeAttribute & AutofocusAttribute & ClassAttribute & EditAttribute & DirectionAttribute & DragAttribute & EnterKeyHintAttribute & HiddenAttribute & InputModeAttribute & IsAttribute & ItemAttribute & ItemIdAttribute & ItemPropertyAttribute & ItemReferenceAttribute & ItemScopeAttribute & ItemTypeAttribute & IdentifierAttribute & LanguageAttribute & NonceAttribute & RoleAttribute & SpellCheckAttribute & StyleAttribute & TabulatorAttribute & TitleAttribute & TranslateAttribute & InertAttribute & PopoverAttribute
+public typealias GlobalAttributes = AccessKeyAttribute & AutocapitalizeAttribute & AutofocusAttribute & ClassAttribute & EditAttribute & DirectionAttribute & DragAttribute & EnterKeyAttribute & HiddenAttribute & InputModeAttribute & IsAttribute & ItemAttribute & ItemIdAttribute & ItemPropertyAttribute & ItemReferenceAttribute & ItemScopeAttribute & ItemTypeAttribute & IdentifierAttribute & LanguageAttribute & NonceAttribute & RoleAttribute & SpellCheckAttribute & StyleAttribute & TabulatorAttribute & TitleAttribute & TranslateAttribute & InertAttribute & PopoverAttribute
 
 /// A type that provides the `accessKey` modifier.
 @_documentation(visibility: internal)
@@ -680,7 +680,7 @@ extension ContentAttribute where Self: EmptyNode {
     }
 }
 
-/// A type that provides the `isEditable` modifier.
+/// A type that provides the `editable` modifier.
 @_documentation(visibility: internal)
 public protocol EditAttribute: Attribute {
 
@@ -690,13 +690,13 @@ public protocol EditAttribute: Attribute {
     /// Blockquote {
     ///     "Lorem ipsum..."
     /// }
-    /// .isEditable(false)
+    /// .editable(false)
     /// ```
     ///
-    /// - Parameter condition: Whether the element should be editable.
+    /// - Parameter value: Whether the element should be editable.
     ///
     /// - Returns: The element
-    func isEditable(_ condition: Bool) -> Self
+    func editable(_ value: Bool) -> Self
 }
 
 extension EditAttribute where Self: ContentNode {
@@ -1028,7 +1028,7 @@ extension DownloadAttribute where Self: EmptyNode {
     }
 }
 
-/// A type that provides the `isDraggable` modifier.
+/// A type that provides the `draggable` modifier.
 @_documentation(visibility: internal)
 public protocol DragAttribute: Attribute {
 
@@ -1038,13 +1038,13 @@ public protocol DragAttribute: Attribute {
     /// Division {
     ///     ...
     /// }
-    /// .isDraggable(false)
+    /// .draggable(false)
     /// ```
     ///
-    /// - Parameter condition: Whether the element should be draggable.
+    /// - Parameter value: Whether the element should be draggable.
     ///
     /// - Returns: The element
-    func isDraggable(_ condition: Bool) -> Self
+    func draggable(_ value: Bool) -> Self
 }
 
 extension DragAttribute where Self: ContentNode {
@@ -1093,32 +1093,32 @@ extension EncodingAttribute where Self: EmptyNode {
     }
 }
 
-/// A type that provides the `enterKeyHint` modifier.
+/// A type that provides the `enterKey` modifier.
 @_documentation(visibility: internal)
-public protocol EnterKeyHintAttribute: Attribute {
+public protocol EnterKeyAttribute: Attribute {
 
     /// Change the enter key for the virtual keyboards.
     ///
     /// ```swift
     /// Input()
     ///     .type(.text)
-    ///     .enterKeyHint(.search)
+    ///     .enterKey(.search)
     /// ```
     ///
     /// - Parameter value: The enter key to apply.
     ///
     /// - Returns: The element
-    func enterKeyHint(_ value: Values.Hint) -> Self
+    func enterKey(_ value: Values.Hint) -> Self
 }
 
-extension EnterKeyHintAttribute where Self: ContentNode {
+extension EnterKeyAttribute where Self: ContentNode {
 
     internal func mutate(enterkeyhint value: String) -> Self {
         return self.mutate(key: "enterkeyhint", value: value)
     }
 }
 
-extension EnterKeyHintAttribute where Self: EmptyNode {
+extension EnterKeyAttribute where Self: EmptyNode {
 
     internal func mutate(enterkeyhint value: String) -> Self {
         return self.mutate(key: "enterkeyhint", value: value)
@@ -1245,7 +1245,7 @@ public protocol EquivalentAttribute: Attribute {
     func equivalent(_ value: Values.Equivalent) -> Self
 }
 
-extension HeaderAttribute where Self: ContentNode {
+extension EquivalentAttribute where Self: ContentNode {
 
     internal func mutate(httpequiv value: String) -> Self {
         return self.mutate(key: "http-equiv", value: value)
@@ -1261,31 +1261,45 @@ extension EquivalentAttribute where Self: EmptyNode {
 
 /// A type that provides the `headers` modifier.
 @_documentation(visibility: internal)
-public protocol HeaderAttribute: Attribute {
+public protocol HeadersAttribute: Attribute {
 
     /// Specify the header cells for an element.
     ///
     /// ```swift
     /// DataCell {
     ///     "Lorem ipsum..."
     /// }
-    /// .headers("ids")
+    /// .headers(["id", "id"])
     /// ```
     ///
     /// - Parameter ids: The identifiers of the cells to associate with.
     ///
     /// - Returns: The element
-    func headers(_ ids: String) -> Self
+    func headers(_ ids: [String]) -> Self
+    
+    /// Specify the header cells for an element.
+    ///
+    /// ```swift
+    /// DataCell {
+    ///     "Lorem ipsum..."
+    /// }
+    /// .headers("id", "id")
+    /// ```
+    ///
+    /// - Parameter ids: The identifiers of the cells to associate with.
+    ///
+    /// - Returns: The element
+    func headers(_ ids: String...) -> Self
 }
 
-extension HeaderAttribute where Self: ContentNode {
+extension HeadersAttribute where Self: ContentNode {
 
     internal func mutate(headers value: String) -> Self {
         return self.mutate(key: "headers", value: value)
     }
 }
 
-extension HeaderAttribute where Self: EmptyNode {
+extension HeadersAttribute where Self: EmptyNode {
 
     internal func mutate(headers value: String) -> Self {
         return self.mutate(key: "headers", value: value)
@@ -1933,20 +1947,57 @@ public protocol LabelAttribute: Attribute {
     ///
     /// - Returns: The element
     func label(_ value: String) -> Self
+    
+    /// Specify a label for the element.
+    ///
+    /// ```swift
+    /// Track()
+    ///     .source("...vtt")
+    ///     .kind(.chapters)
+    ///     .label("lorem")
+    /// ```
+    ///
+    /// - Parameter localizedKey: The string key to be translated.
+    /// - Parameter tableName: The translation table to look in.
+    ///
+    /// - Returns: The element
+    func label(_ localizedKey: LocalizedStringKey, tableName: String?) -> Self
+    
+    /// Specify a label for the element without localization.
+    ///
+    /// ```swift
+    /// Track()
+    ///     .source("...vtt")
+    ///     .kind(.chapters)
+    ///     .label(verbatim: "lorem")
+    /// ```
+    ///
+    /// - Parameter value: The text to use as a label.
+    ///
+    /// - Returns: The element
+    func label(verbatim value: String) -> Self
 }
 
 extension LabelAttribute where Self: ContentNode {
 
     internal func mutate(label value: String) -> Self {
         return self.mutate(key: "label", value: value)
     }
+    
+    internal func mutate(label value: LocalizedString) -> Self {
+        return self.mutate(key: "label", value: value)
+    }
 }
 
 extension LabelAttribute where Self: EmptyNode {
 
     internal func mutate(label value: String) -> Self {
         return self.mutate(key: "label", value: value)
     }
+    
+    internal func mutate(label value: LocalizedString) -> Self {
+        return self.mutate(key: "label", value: value)
+    }
 }
 
 /// A type that provides the `language` modifier.
@@ -2452,7 +2503,7 @@ extension NoValidateAttribute where Self: EmptyNode {
     }
 }
 
-/// A type that provides the `isOpen` modifier.
+/// A type that provides the `open` modifier.
 @_documentation(visibility: internal)
 public protocol OpenAttribute: Attribute {
 
@@ -2467,25 +2518,25 @@ public protocol OpenAttribute: Attribute {
     ///         "Lorem ipsum..."
     ///     }
     /// }
-    /// .isOpen(true)
+    /// .open(true)
     /// ```
     ///
     /// - Parameter condition: Whether the details should be open.
     ///
     /// - Returns: The element
-    func isOpen(_ condition: Bool) -> Self
+    func open(_ condition: Bool) -> Self
 }
 
 extension OpenAttribute where Self: ContentNode {
 
-    internal func mutate(open value: Bool) -> Self {
+    internal func mutate(open value: String) -> Self {
         return self.mutate(key: "open", value: value)
     }
 }
 
 extension OpenAttribute where Self: EmptyNode {
 
-    internal func mutate(open value: Bool) -> Self {
+    internal func mutate(open value: String) -> Self {
         return self.mutate(key: "open", value: value)
     }
 }
@@ -3136,17 +3187,28 @@ extension ScopeAttribute where Self: EmptyNode {
 @_documentation(visibility: internal)
 public protocol ShapeAttribute: Attribute {
 
+    /// Define the entire area as shape.
+    ///
+    /// ```swift
+    /// Area()
+    ///     .shape()
+    /// ```
+    ///
+    /// - Returns: The element
+    func shape() -> Self
+    
     /// Define the shape for an area.
     ///
     /// ```swift
     /// Area()
-    ///     .shape(.circle)
+    ///     .shape(.rect, coordinates: "0, 0, 200, 100")
     /// ```
     ///
     /// - Parameter value: The shape used to interpret the coordinates.
+    /// - Parameter coordinates: The coordinates on which to base the shape.
     ///
     /// - Returns: The element
-    func shape(_ value: Values.Shape) -> Self
+    func shape(_ value: Values.Shape, coordinates: String) -> Self
 }
 
 extension ShapeAttribute where Self: ContentNode {
@@ -3298,21 +3360,21 @@ extension SpanAttribute where Self: EmptyNode {
     }
 }
 
-/// A type that provides the `hasSpellCheck` modifier.
+/// A type that provides the `spellcheck` modifier.
 @_documentation(visibility: internal)
 public protocol SpellCheckAttribute: Attribute {
 
     /// Mark a element as spellchecked.
     ///
     /// ```swift
     /// Input()
-    ///     .hasSpellCheck(false)
+    ///     .spellcheck(false)
     /// ```
     ///
-    /// - Parameter condition: Whether to spellcheck the content.
+    /// - Parameter value: Whether to spellcheck the content.
     ///
     /// - Returns: The element
-    func hasSpellCheck(_ condition: Bool) -> Self
+    func spellcheck(_ value: Bool) -> Self
 }
 
 extension SpellCheckAttribute where Self: ContentNode {
@@ -3708,13 +3770,13 @@ public protocol TranslateAttribute: Attribute {
     /// Paragraph {
     ///     "Lorem ipsum..."
     /// }
-    /// .translate(.no)
+    /// .translate(true)
     /// ```
     ///
     /// - Parameter value: Whether to exclude the content from translation.
     ///
     /// - Returns: The element
-    func translate(_ value: Values.Decision) -> Self
+    func translate(_ value: Bool) -> Self
 }
 
 extension TranslateAttribute where Self: ContentNode {
@@ -3776,8 +3838,7 @@ public protocol UseMapAttribute: Attribute {
     ///     .useMap("...")
     /// Map {
     ///     Area()
-    ///         .shape(.circle)
-    ///         .coordinates(...)
+    ///         .shape(.circle, coordinates: "...")
     /// }
     /// .name("...")
     /// ```
@@ -4278,27 +4339,46 @@ public protocol PopoverTargetAttribute: Attribute {
     /// Button {
     ///     "Lorem ipsum"
     /// }
-    /// .popoverTarget("id")
+    /// .popoverTarget("id", action: .hide)
     /// ```
     ///
     /// - Parameter id: The identifier of the target to bind the popover to.
+    /// - Parameter action: The action to perform when triggered.
     ///
     /// - Returns: The element
-    func popoverTarget(_ id: String) -> Self
+    func popoverTarget(_ id: String, action: Values.Popover.Action?) -> Self
 }
 
 extension PopoverTargetAttribute where Self: ContentNode {
 
     internal func mutate(popovertarget value: String) -> Self {
         return self.mutate(key: "popovertarget", value: value)
     }
+    
+    internal func mutate(popovertargetaction value: String?) -> Self {
+        
+        if let value = value {
+            return self.mutate(key: "popovertargetaction", value: value)
+        }
+        
+        return self
+    }
 }
 
 extension PopoverTargetAttribute where Self: EmptyNode {
 
     internal func mutate(popovertarget value: String) -> Self {
         return self.mutate(key: "popovertarget", value: value)
     }
+    
+    internal func mutate(popovertargetaction value: String?) -> Self {
+        
+        if let value = value {
+            return self.mutate(key: "popovertargetaction", value: value)
+        }
+        
+        return self
+    }
 }
 
 /// A type that provides the `popoverAction` modifier