Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select multiple files #90

Open
K-RAD opened this issue Aug 19, 2014 · 11 comments
Open

Select multiple files #90

K-RAD opened this issue Aug 19, 2014 · 11 comments

Comments

@K-RAD
Copy link

K-RAD commented Aug 19, 2014

Select multiple files for Enqueue/Delete

@adrian-bl
Copy link
Member

How would this work in the UI?

Wouldn't it contradict the long-press-for-context-menu?

@K-RAD
Copy link
Author

K-RAD commented Oct 16, 2014

Here's an example, similar to I saw in other apps:

In a playlistview, you have a button "Add multiple" which opens the Library with all the items checkable (no context menus) and a button to Confirm. The same principle can be applied in Now Playing view for "Enqueue multiple"

@mathstuf
Copy link
Contributor

I like the way K-9 Mail does it where once one item is selected, it goes into a "selection mode" where any click will select or deselect an item in the list. Would adding "Select" in the context menu to go into this mode be too confusing for users (a persistent checkbox might clutter too much)?

@adrian-bl
Copy link
Member

Yeah: I really dislike K9 Mails select mode - IMO, it is much more common to do a longpress in Vanilla music to perform an action (play, enqueue, delete) on a single file/album.

Maybe it would be wise to include a 'Select this item' in the long-press context menu?

@mathstuf
Copy link
Contributor

That's pretty much just as slow as singly adding songs to playlists (except the scrolling). A single click should be all it takes to select songs once that's what is happening. Whether a separate activity pops up or not isn't really as much of am concern to me.

@adrian-bl
Copy link
Member

But i really would like to keep the 'context menu on longpress' as a default.
Always going into selection mode on longpress would be very cumbersome.

So how about this:

  • Longpress on a file open the normal context menu + a new 'Select file' entry
  • After you hit 'Select file', you are in the multifile-select mode and can select as many files as you like using a single click

@mathstuf
Copy link
Contributor

Sounds like a good compromise to me. Might want '…' at the end to signal there's something more to come after selecting the entry.

@K-RAD
Copy link
Author

K-RAD commented Oct 19, 2014

If you can, check how 99M does it in a playlists. I see that it's not free anymore. It has a button like "Edit" for rearranging, and a button for multiple select which opens the library in a checkable mode.
I also like about it that it has rearranging in queue

Rocket Player has also a way to multiple select, though it's not as nice.

@adrian-bl
Copy link
Member

Rearranging the queue will be included in the next release (already in git).

Well: I will think about how i can implement this in a sane way (UI-wise) but this has currently medium priority for me.

However: Contributions/Pull Requests are welcome!

@adrian-bl
Copy link
Member

-> Closing all open bugs as vanilla was removed from the play store by some DMCA-Troll, see: https://plus.google.com/115564237657785223556/posts/TvY1PD4ci2N

@un-logic
Copy link

un-logic commented May 6, 2016

What about simply touching an icon of album cover to select current item one by one, then to call context menu, just long press on any area of any one of selected items or move a cluster of selection to a disired position usung existing 8-dotted handles instead? Deselection of item should be performed same way plus a special button or context menu action to Select/deselect all that appear only upon selection start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants