Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Requests #492

Open
pjlbgh opened this issue Dec 26, 2016 · 2 comments
Open

Feature Requests #492

pjlbgh opened this issue Dec 26, 2016 · 2 comments

Comments

@pjlbgh
Copy link

pjlbgh commented Dec 26, 2016

This music player is really nice, better than what's offered on the Play Store even. I didn't find anywhere else to ask for features to be added so I figured I'd post here.

  • Customize how far the seek function works (Settings > Playback screen > Swipe up/down action > Seek 10 seconds forward/backward), right now you can only go forward/backward by 10 seconds. It'd be nice to set it to a custom interval, usually 15-30 seconds is the sweet spot.

  • Set bookmarks for specific tracks, useful when listening to longer tracks like audiobooks. Material Player (also on fdroid) is what I'm using right now for audiobooks and does this functionality well, pretty much the only reason I use it over Vanilla. You might nest this within a "jump to time xx:xx:xx" function.

  • A cosmetic request, I keep my music organized in my filesystem (who doesn't?), and only ever use the "files" tab since it's easy enough to browse by folder. It'd be nice if, when you only use 1 tab, for it not to appear in the library screen. Opens up more screen space.

I feel kinda bad asking, since this is all volunteer work, but I just wanted to throw this out there and see if anyone else agrees. This really is a good program. Thanks for making it free. If there's a place to send Bitcoin donations I wouldn't mind returning the favor. Thanks again.

@adrian-bl
Copy link
Member

usually 15-30 seconds is the sweet spot.

Do you feel that this really needs to be a config option or would changing the default from 10 to 15 seconds be good enough? (I never used this feature myself)

Set bookmarks for specific tracks

I am absolutely not an audiobook persion: so how would this work? Would it be like a playlist which also saves the position of each entry?

and only ever use the "files" tab since it's easy enough to browse by folder.

That makes sense and would probably be easy to implement

@pjlbgh
Copy link
Author

pjlbgh commented Dec 28, 2016

Honestly the seek function works fine as it is now, it's really a matter of opinion how much time it should skip, hence why a config option would be optimal. Set it to 20 seconds and someone will complain it should be 10 seconds.. you know. 10 seconds works fine. I use this feature very often, with tracks >15m it's impossible to find the position you want by tapping the seekbar (whatever the blue time-progress bar is called). When I'm listening to lectures/podcasts and the speaker says something particularly interesting it's necessary to be able to skip back a few minutes to rehear what they said. I also have some albums that are single audio files, and being able to skip through songs is quite useful.

Bookmarks are pretty much the same function as "jump to xx:xx:xx" (ie, for a track 10 minutes long, enter 00:04:20 to go 4 minutes and 20 seconds into the track), and then saving that specific time to revisit later, usually with a text label. Check out 'Material Player' on F-droid to see what I mean. It is a little fancy, although I think a "jump to xx:xx:xx" function is pretty standard amongst media players. You'd have to implement that function before adding bookmarks, I believe.

If all this seems unnecessary for Vanilla I can continue using Material Player for my longer audio files, Vanilla's interface is just more pleasant. It'd be nice to hear what others think before any changes are made to the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants