Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Disable the navigation above the library "Startfolder" (Do not navigate outside the defined Music folder) #397

Open
Wikinaut opened this issue Jul 9, 2016 · 2 comments

Comments

@Wikinaut
Copy link

Wikinaut commented Jul 9, 2016

I suggest to disable any navigation "above" the defined Startfolder. I don't see any reason for allowing the user to navigate outside the Startfolder.

And, by mistake, I often used the return key too often, so that I landed in the top menu of my Android and had manually to find back my Startfolder.

Alternative solution: add a quick button to go the defined "Startfolder".

@omertuc
Copy link

omertuc commented Sep 10, 2016

I created a pull request #436 resolving this ... I hope they merge it

@adrian-bl
Copy link
Member

Thanks for the PR, but the code looks overly complex to me:

Wouldn't it be simpler to just compare Limiter.names of mLimiter and limiter to check if: limiter is shorter than mLimiter && all elements of limiter exist in mLimiter ? This way there would be no need to create a file object.

Also note that the code returns too early if limiter is null AND the feature is enabled (eg: it wouldn't kill existing observers and will not reset mLimiter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants