Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep timer #157

Open
ToNIX- opened this issue Apr 7, 2015 · 8 comments
Open

Sleep timer #157

ToNIX- opened this issue Apr 7, 2015 · 8 comments

Comments

@ToNIX-
Copy link

ToNIX- commented Apr 7, 2015

Any plans on adding a simple sleep timer in Vanilla Music (Menu > Sleep timer)?

I know it can be achieved with the "Idle Timeout" option in Settings > Miscellaneous.

However, once activated, the "Idle Timeout" stays active forever, unless unchecked. I think that adding an option that would deactivate the "Idle Timeout" once done would make sense. The checkbox could be name something like "Disable once done" and grayed out unless "Idle Timeout" is checked.

Thanks :)

@adrian-bl adrian-bl modified the milestones: 1.0, 1.0.1 Apr 23, 2015
@adrian-bl
Copy link
Member

Thinking about it, i feel like this should be the default anyway: I often find myself having the idle-timeout active by mistake.

So i'll have the idle-timeout automatically disable itself if there are no objections

@adrian-bl adrian-bl modified the milestones: 1.0.3, 1.0.1 May 15, 2015
@Allanitomwesh
Copy link

It could just disable itself after it reaches the timeout. That would be a sleep timer already. Then the checkbox would be "Always Timeout" and greyed out,that would maintain current behaviour

@ToNIX-
Copy link
Author

ToNIX- commented Aug 22, 2015

Looks good to me, it should at least disable itself automatically once it reaches the timeout.

@adrian-bl adrian-bl removed this from the 1.0.3 milestone Sep 23, 2015
@ToNIX-
Copy link
Author

ToNIX- commented Mar 25, 2016

Any news on this one? I tried to play in the code but hmmm. Haven't touched programming since almost 10 years, let alone Android programming. I do somewhat understand how it works, but can't reset the idle_timeout preference.

@adrian-bl
Copy link
Member

No, sorry: i did not have time to work on this.

but can't reset the idle_timeout preference.

The code should get an instance of the SharedPreferencesEditor after the idle timeout was hit, eg:

SharedPreferences.Editor editor = PlaybackService.getSettings(this).edit();
editor.putBoolean(PrefKeys.USE_IDLE_TIMEOUT, false);
editor.commit();

@adrian-bl adrian-bl added this to the 1.0.50 milestone May 16, 2016
@M1Aston
Copy link

M1Aston commented Sep 30, 2018

Yes, please add a real sleep timer. The timeout option is too limited. Other players have option like

  • stop playing after x number of files.
  • stop after x hours\minutes.
  • stop after x hours\minutes but always finish the playing file.
  • close the program instead after stopping playback.

Please improve the sleep timer.

@M1Aston
Copy link

M1Aston commented Nov 20, 2018

Yes, please add a a real sleep timer, with (some of) the options mentioned above. :-)

@LivInTheLookingGlass
Copy link

Is this a planned feature still?

Wiguwbe added a commit to Wiguwbe/vanilla that referenced this issue Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants