Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update timezone/dst from coordinates using timezonefinder #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

verhovsky
Copy link
Contributor

@verhovsky verhovsky commented Mar 13, 2021

Fixes #9 (kinda, assuming all the coordinates are correct. 57532 looks like it stradles two timezones for instance.)

@verhovsky verhovsky marked this pull request as draft March 13, 2021 08:00
@verhovsky
Copy link
Contributor Author

verhovsky commented Mar 13, 2021

I noticed that

33041,Key West,FL,25.100957,-81.568862,-5,1
33045,Key West,FL,25.100957,-81.568862,-5,1

incorrectly have coordinates out in the Gulf of Mexico, which sets their timezone to the wrong timezone.

I was confused by Dutch Harbor, Alaska. The data and Google said it's in HAST UTC-10 but timezonefinder says AST UTC-9. A map of timezones shows that the AST/HAST boundary is way further west of Unalaska, so I guess they're just wrong and -9 is correct.

-99692,Dutch Harbor,AK,53.883729,-166.5485,-10,1
+99692,Dutch Harbor,AK,53.883729,-166.5485,-9,1

@verhovsky verhovsky force-pushed the update-timezones branch 2 times, most recently from db11ae5 to 9db3403 Compare March 13, 2021 08:47
86036,Marble Canyon,AZ,36.618595,-111.85444,-7,0
86038,Mormon Lake,AZ,34.908287,-111.463026,-7,0
86039,Kykotsmovi Village,AZ,36.00059,-110.5201,-7,0
86040,Page,AZ,36.726377,-111.4284,-7,0
86040,Page,AZ,36.726377,-111.4284,-7,1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Page, Arizona doesn't observe DST according to https://www.timetemperature.com/tzaz/page.shtml

The coordinate is quite a ways south of the town.

@verhovsky verhovsky marked this pull request as ready for review March 19, 2021 03:59
@verhovsky
Copy link
Contributor Author

I marked this as "ready for review" but only the code part is done. The actual updates to the data should be checked thoroughly and the coordinates for at least one of these zip codes needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timezone data is outdated
1 participant