replace strcmp with byte-by-byte comparison in aof

[MuradSh]

Issue #2792

Replace strcmp with byte-by-byte comparison to avoid accidental heap-buffer-overflow errors.

[sarthakaggarwal97]

Do you mean #2792 in the PR description?

[MuradSh]

Oops, yeah. I updated the description.

[JimB123]

LGTM - but see comment on the issue: #2792 (comment)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.43%. Comparing base (32844b8) to head (7c456b5).
⚠️ Report is 41 commits behind head on unstable.

Additional details and impacted files

@@             Coverage Diff              @@
##           unstable    #2809      +/-   ##
============================================
+ Coverage     72.41%   72.43%   +0.02%     
============================================
  Files           128      128              
  Lines         70261    70261              
============================================
+ Hits          50879    50897      +18     
+ Misses        19382    19364      -18     

Files with missing lines	Coverage Δ
src/valkey-check-aof.c	73.80% <100.00%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.