Skip to content

Make implicit ACL categories explicit in JSON files #417

@zuiderkwast

Description

@zuiderkwast

The JSON files describing the commands include ACL categories, but these are not the final ACL categories used. Valkey adds some implicit ones depending on "command flags" which are also from the same JSON files.

To remove this discrepancy and make the JSON files more usable as-is, we'd need:

  • Add all implicit ACL categories in the JSON files,
  • Validate that the JSON files follow the rules for implicit ACL categories. This can be done in utils/generate-command-code.py.
  • Remove the code that adds implicit ACL categories, the function setImplicitACLCategories() in
    server.c.

This is a follow-up of #403.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions