Skip to content

Commit 634d5da

Browse files
committed
Fix minor cluster issues
1 parent e50667b commit 634d5da

File tree

5 files changed

+10
-5
lines changed

5 files changed

+10
-5
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ To deploy the cluster mode using the local chart files:
3131

3232
```bash
3333
# Navigate to the directory containing the chart
34-
cd fork_valkey_helm/valkey-helm
34+
cd ./valkey-helm
3535

3636
# Install the chart from local files
3737
helm install valkey-cluster ./valkey-cluster
@@ -41,7 +41,7 @@ helm install valkey-cluster ./valkey-cluster
4141
You can customize the installation by providing values:
4242

4343
```bash
44-
helm install valkey-cluster ./valkey-cluster --values my-values.yaml
44+
helm install valkey-cluster ./valkey-cluster -f my-values.yaml
4545
```
4646

4747
Cluster mode features:

valkey-cluster/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ This minimum of 6 nodes typically represents:
3434
| dataStorage.persistentVolumeClaimName | string | `nil` | |
3535
| dataStorage.requestedSize | string | `nil` | |
3636
| dataStorage.volumeName | string | `"valkey-data"` | |
37+
| extraInitContainers | list | `[]` | |
3738
| env | object | `{}` | |
3839
| existingSecret | string | `""` | |
3940
| existingSecretPasswordKey | string | `""` | |

valkey-cluster/templates/cluster_config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ data:
120120
done
121121
NODES="${NODES} ${NODE_HOST}:6379"
122122
done
123+
sleep 6
123124
124125
echo "Creating cluster with nodes: ${NODES}"
125126
echo "yes" | valkey-cli ${AUTH_OPTION} --cluster create ${NODES} --cluster-replicas "${REPLICA_COUNT}"

valkey-cluster/templates/deploy_valkey.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{{- $fullname := include "valkey-cluster.fullname" . }}
22
{{- $storage := .Values.dataStorage }}
33
{{- $useExistingPVC := and $storage.enabled (not (empty $storage.persistentVolumeClaimName)) }}
4-
{{- $createPVC := and $storage.enabled (not (empty $storage.requestedSize)) (empty $storage.persistentVolumeClaimName) }}{{- $useConfigMap := or (not (empty .Values.valkeyConfig)) (gt (int .Values.replicaCount) 1) -}}
4+
{{- $createPVC := and $storage.enabled (not (empty $storage.requestedSize)) (empty $storage.persistentVolumeClaimName) }}{{- $useConfigMap := or (not (empty .Values.valkeyConfig | default "")) (gt (int .Values.replicaCount) 1) -}}
55
{{- $configFile := "/data/conf/valkey.conf" -}}
66

77
apiVersion: apps/v1
@@ -195,7 +195,7 @@ spec:
195195
- name: http-metrics
196196
containerPort: {{ .Values.metrics.containerPorts.http }}
197197
{{- if .Values.metrics.resources }}
198-
resources: {{- toYaml .Values.metrics.resources | nindent 12 }}}
198+
resources: {{- toYaml .Values.metrics.resources | nindent 12 }}
199199
{{- end }}
200200
{{- end }}
201201

valkey-cluster/values.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ containerPorts:
1717

1818
podDisruptionBudget: {}
1919

20-
podLabels: {}
20+
valkeyAnnotations: {}
2121

2222
commonLabels: {}
2323

@@ -235,6 +235,8 @@ lifecycleHooks:
235235
# Mount additional configMaps into the Valkey container
236236
extraValkeyConfigs: []
237237

238+
extraInitContainers: []
239+
238240
# Mount extra secrets as volume to init container (deprecated, use extraValkeySecrets)
239241
extraSecretValkeyConfigs: false
240242

@@ -291,6 +293,7 @@ metrics:
291293
service:
292294
type: ClusterIP
293295
clusterIP: ""
296+
labels: {}
294297

295298

296299
containerPorts:

0 commit comments

Comments
 (0)