Refactor Redis commands and remove ACL feature

- Removed ACL command implementations from `mod.rs` and associated tests.
- Cleaned up connection handling in `connection.rs` by simplifying TLS configuration.
- Deleted the `script.rs` module and its related tests
- Updated various test files to remove references to script-related tests.
- Adjusted cluster tests to improve key handling and slot calculations.
- Enhanced utility functions for better TLS setup in tests.

Signed-off-by: Avi Fenesh <[email protected]>

Author: avifenesh

.vscode/settings.json

@@ -62,6 +62,8 @@
         "black"
     ],
     "rust-analyzer.cargo.features": "all",
+    "rust-analyzer.procMacro.enable": true,
+    "rust-analyzer.cargo.buildScripts.enable": true,
     "dotnet.defaultSolution": "csharp/csharp.sln",
     "java.compile.nullAnalysis.mode": "automatic",
     "java.configuration.updateBuildConfiguration": "interactive",

glide-core/Cargo.toml

@@ -13,6 +13,7 @@ bytes = "1"
 futures = "^0.3"
 redis = { path = "./redis-rs/redis", features = [
     "aio",
+    "keep-alive",
     "tokio-comp",
     "tokio-rustls-comp",
     "connection-manager",
@@ -58,12 +59,13 @@ standalone_heartbeat = []
 rsevents = "0.3.1"
 socket2 = "^0.5"
 tempfile = "3.3.0"
-rstest = "^0.23"
+rstest = "^0.25"
 serial_test = "3"
-criterion = { version = "^0.5", features = ["html_reports", "async_tokio"] }
-which = "6"
-ctor = "0.2.2"
+criterion = { version = "^0.6", features = ["html_reports", "async_tokio"] }
+which = "7"
+ctor = "0.4"
 redis = { path = "./redis-rs/redis", features = ["tls-rustls-insecure"] }
+rustls = { version = "0.23", features = ["ring"], default-features = false}
 iai-callgrind = "0.14"
 tokio = { version = "1", features = ["rt-multi-thread"] }
 glide-core = { path = ".", features = [

glide-core/benches/rotating_buffer_benchmark.rs

@@ -1,9 +1,9 @@
 // Copyright Valkey GLIDE Project Contributors - SPDX Identifier: Apache-2.0
 
-use std::{io::Write, ptr::from_mut};
+use std::{hint::black_box, io::Write, ptr::from_mut};
 
 use bytes::BufMut;
-use criterion::{Criterion, black_box, criterion_group, criterion_main};
+use criterion::{Criterion, criterion_group, criterion_main};
 use glide_core::{
     command_request::{Command, CommandRequest, RequestType},
     command_request::{command, command_request},

glide-core/redis-rs/redis/Cargo.toml

@@ -26,18 +26,15 @@ ryu = "1.0"
 itoa = "1.0"
 
 # Strum is a set of macros and traits for working with enums and strings easier in Rust.
-strum = "0.26"
-strum_macros = "0.26"
+strum = "0.27"
+strum_macros = "0.27"
 
 # This is a dependency that already exists in url
 percent-encoding = "2.1"
 
 # We need this for redis url parsing
 url = "2.5.4"
 
-# We need this for script support
-sha1_smol = { version = "1.0", optional = true }
-
 combine = { version = "4.6", default-features = false, features = ["std"] }
 
 # Only needed for AIO
@@ -73,10 +70,10 @@ native-tls = { version = "0.2", optional = true }
 tokio-native-tls = { version = "0.3", optional = true }
 
 # Only needed for rustls
-rustls = { version = "0.22", optional = true }
-webpki-roots = { version = "0.26", optional = true }
-rustls-native-certs = { version = "0.7", optional = true }
-tokio-rustls = { version = "0.25", optional = true }
+rustls = { version = "0.23", features = ["ring"], default-features = false, optional = true }
+
+rustls-native-certs = { version = "0.8", optional = true }
+tokio-rustls = { version = "0.26", default-features = false, optional = true }
 rustls-pemfile = { version = "2", optional = true }
 rustls-pki-types = { version = "1", optional = true }
 
@@ -103,18 +100,14 @@ lazy_static = "1"
 
 [features]
 default = [
-    "acl",
-    "streams",
-    "geospatial",
-    "script",
+    "aio",
     "keep-alive",
     "tokio-comp",
     "tokio-rustls-comp",
     "connection-manager",
     "cluster",
     "cluster-async",
 ]
-acl = []
 aio = [
     "bytes",
     "pin-project-lite",
@@ -131,7 +124,6 @@ aio = [
 geospatial = []
 json = ["serde", "serde/derive", "serde_json"]
 cluster = ["crc16", "rand"]
-script = ["sha1_smol"]
 tls-native-tls = ["native-tls"]
 tls-rustls = [
     "rustls",
@@ -140,7 +132,7 @@ tls-rustls = [
     "rustls-pki-types",
 ]
 tls-rustls-insecure = ["tls-rustls"]
-tls-rustls-webpki-roots = ["tls-rustls", "webpki-roots"]
+
 tokio-comp = ["aio", "tokio/net", "tokio-retry2"]
 tokio-native-tls-comp = ["tokio-comp", "tls-native-tls", "tokio-native-tls"]
 tokio-rustls-comp = ["tokio-comp", "tls-rustls", "tokio-rustls"]
@@ -160,13 +152,13 @@ disable-client-setinfo = []
 tls = ["tls-native-tls"] # use "tls-native-tls" instead
 
 [dev-dependencies]
-rand = "0.8"
+rand = "0.9"
 socket2 = "0.5"
 assert_approx_eq = "1.0"
 fnv = "1.0.5"
 futures = "0.3"
 futures-time = "3"
-criterion = "0.4"
+criterion = "0.6"
 partial-io = { version = "0.5", features = ["tokio", "quickcheck1"] }
 quickcheck = "1.0.3"
 tokio = { version = "1", features = [
@@ -175,13 +167,13 @@ tokio = { version = "1", features = [
     "rt-multi-thread",
     "time",
 ] }
-tempfile = "=3.6.0"
+tempfile = "3"
 once_cell = "1"
 anyhow = "1"
 sscanf = "0.4.1"
-serial_test = "^2"
-versions = "6.3"
-which = "7.0.1"
+serial_test = "3"
+versions = "7"
+which = "7"
 tracing-subscriber = { version = "0.3", features = ["fmt", "env-filter"] }
 
 [[test]]
@@ -192,9 +184,6 @@ required-features = ["tokio-comp"]
 name = "parser"
 required-features = ["aio"]
 
-[[test]]
-name = "test_acl"
-
 [[test]]
 name = "test_module_json"
 required-features = ["json", "serde/derive"]

glide-core/redis-rs/redis/benches/bench_cluster.rs

@@ -1,7 +1,8 @@
 #![allow(clippy::unit_arg)] // want to allow this for `black_box()`
 #![cfg(feature = "cluster")]
-use criterion::{black_box, criterion_group, criterion_main, Criterion, Throughput};
+use criterion::{criterion_group, criterion_main, Criterion, Throughput};
 use redis::cluster::cluster_pipe;
+use std::hint::black_box;
 
 use support::*;
 

glide-core/redis-rs/redis/benches/bench_cluster_async.rs

@@ -1,8 +1,9 @@
 #![allow(clippy::unit_arg)] // want to allow this for `black_box()`
 #![cfg(feature = "cluster")]
-use criterion::{black_box, criterion_group, criterion_main, Criterion};
+use criterion::{criterion_group, criterion_main, Criterion};
 use futures_util::{stream, TryStreamExt};
 use redis::RedisError;
+use std::hint::black_box;
 
 use support::*;
 use tokio::runtime::Runtime;