Environment may prevent Vigil from starting on Rocky Linux

[eKristensen]

Hi,

When starting vigil directly in a bash shell from e.g. a SSH session I get the following error:

[root@pop-rocky-4gb-fsn1-1 vigil]# vigil -c ./vigil.cfg
thread 'main' panicked at 'cannot substitute environment variables: Error("variable value '() {  ( alias;\n eval ${which_declare} ) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot $@\n}' contains forbidden character '$'")', /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/vigil-server-1.26.3/src/config/reader.rs:32:48
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Aborted (core dumped)

OS is Rocky Linux 9

The same machine can run vigil via systemd.

I think that vigil looks into more environment variables than it should and finds something it does not like. I think it would be better if vigil just ignored what environment variables it has nothing to do with contains.

I have no issues starting vigil directly this way on Debian.

Why start vigil like this? For debugging and trying stuff.

Best regards,
Emil Kristensen

[valeriansaliou]

Can you send your Vigil configuration file over here? You might be doing ENV var expansion somewhere.

[eKristensen]

I'm using the example config from this repo, so sending the config is really easy: https://github.com/valeriansaliou/vigil/blob/master/config.cfg

[valeriansaliou]

Can you print your whole env here?

[eKristensen]

[root@pop-rocky-4gb-fsn1-1 ~]# printenv
SHELL=/bin/bash
HISTCONTROL=ignoredups
HISTSIZE=1000
HOSTNAME=pop-rocky-4gb-fsn1-1
PWD=/root
LOGNAME=root
XDG_SESSION_TYPE=tty
MOTD_SHOWN=pam
HOME=/root
LANG=en_US.UTF-8
LS_COLORS=rs=0:di=01;34:ln=01;36:mh=00:pi=40;33:so=01;35:do=01;35:bd=40;33;01:cd=40;33;01:or=40;31;01:mi=01;37;41:su=37;41:sg=30;43:ca=30;41:tw=30;42:ow=34;42:st=37;44:ex=01;32:*.tar=01;31:*.tgz=01;31:*.arc=01;31:*.arj=01;31:*.taz=01;31:*.lha=01;31:*.lz4=01;31:*.lzh=01;31:*.lzma=01;31:*.tlz=01;31:*.txz=01;31:*.tzo=01;31:*.t7z=01;31:*.zip=01;31:*.z=01;31:*.dz=01;31:*.gz=01;31:*.lrz=01;31:*.lz=01;31:*.lzo=01;31:*.xz=01;31:*.zst=01;31:*.tzst=01;31:*.bz2=01;31:*.bz=01;31:*.tbz=01;31:*.tbz2=01;31:*.tz=01;31:*.deb=01;31:*.rpm=01;31:*.jar=01;31:*.war=01;31:*.ear=01;31:*.sar=01;31:*.rar=01;31:*.alz=01;31:*.ace=01;31:*.zoo=01;31:*.cpio=01;31:*.7z=01;31:*.rz=01;31:*.cab=01;31:*.wim=01;31:*.swm=01;31:*.dwm=01;31:*.esd=01;31:*.jpg=01;35:*.jpeg=01;35:*.mjpg=01;35:*.mjpeg=01;35:*.gif=01;35:*.bmp=01;35:*.pbm=01;35:*.pgm=01;35:*.ppm=01;35:*.tga=01;35:*.xbm=01;35:*.xpm=01;35:*.tif=01;35:*.tiff=01;35:*.png=01;35:*.svg=01;35:*.svgz=01;35:*.mng=01;35:*.pcx=01;35:*.mov=01;35:*.mpg=01;35:*.mpeg=01;35:*.m2v=01;35:*.mkv=01;35:*.webm=01;35:*.webp=01;35:*.ogm=01;35:*.mp4=01;35:*.m4v=01;35:*.mp4v=01;35:*.vob=01;35:*.qt=01;35:*.nuv=01;35:*.wmv=01;35:*.asf=01;35:*.rm=01;35:*.rmvb=01;35:*.flc=01;35:*.avi=01;35:*.fli=01;35:*.flv=01;35:*.gl=01;35:*.dl=01;35:*.xcf=01;35:*.xwd=01;35:*.yuv=01;35:*.cgm=01;35:*.emf=01;35:*.ogv=01;35:*.ogx=01;35:*.aac=01;36:*.au=01;36:*.flac=01;36:*.m4a=01;36:*.mid=01;36:*.midi=01;36:*.mka=01;36:*.mp3=01;36:*.mpc=01;36:*.ogg=01;36:*.ra=01;36:*.wav=01;36:*.oga=01;36:*.opus=01;36:*.spx=01;36:*.xspf=01;36:
SSH_CONNECTION=[Censored IPv6 addr] 46720 [Censored IPv6 addr] 22
XDG_SESSION_CLASS=user
SELINUX_ROLE_REQUESTED=
TERM=xterm-256color
LESSOPEN=||/usr/bin/lesspipe.sh %s
USER=root
SELINUX_USE_CURRENT_RANGE=
SHLVL=1
XDG_SESSION_ID=24
XDG_RUNTIME_DIR=/run/user/0
SSH_CLIENT=[Censored IPv6 addr] 46720 22
DEBUGINFOD_URLS=https://debuginfod.centos.org/ 
which_declare=declare -f
XDG_DATA_DIRS=/usr/local/share:/usr/share:/var/lib/snapd/desktop
PATH=/root/.local/bin:/root/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/var/lib/snapd/snap/bin
SELINUX_LEVEL_REQUESTED=
DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/0/bus
MAIL=/var/spool/mail/root
SSH_TTY=/dev/pts/0
BASH_FUNC_which%%=() {  ( alias;
 eval ${which_declare} ) | /usr/bin/which --tty-only --read-alias --read-functions --show-tilde --show-dot $@
}
_=/usr/bin/printenv

[mshedsilegx]

I could reproduce, and it seems due to systemd injecting functions BASH_FUNC_xxxx

env -i ./vigil -c ./vigil.cfg

worked for me

[davidsenk]

I can confirm that this also affects the default install of Alma Linux 9.

To fix I commented out the following lines in src/config/reader.rs

//let environment = env::vars().collect::<HashMap<String, String>>();
//conf = substitute(&conf, &environment).expect("cannot substitute environment variables");

After doing this and recompiling, issue was resolved. This is fine form me as I'm not using any env config...

Agreed with @eKristensen that it appears Vigil is being a bit too introspective on the env at start... Potentially a bug in envsubst crate as usage in Vigil seems reasonable