Skip to content

Commit 210ec3a

Browse files
committed
Make OpenFX strings static
Oops, turns out these *do* need to be static: https://openfx.readthedocs.io/en/main/Reference/ofxCoreAPI.html#strings This miiiiight fix the Nuke crash?
1 parent dbb2025 commit 210ec3a

File tree

2 files changed

+129
-68
lines changed

2 files changed

+129
-68
lines changed

crates/ntscrs/src/settings/settings.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,7 @@ impl From<bool> for AnySetting {
191191
pub trait SettingsEnum: FromPrimitive + ToPrimitive {}
192192

193193
/// A fixed identifier that points to a given setting. The id and name cannot be changed or reused once created.
194-
#[derive(Debug, PartialEq, Eq, Clone)]
194+
#[derive(Debug, Clone)]
195195
pub struct SettingID<T: Settings> {
196196
pub id: u32,
197197
pub name: &'static str,
@@ -210,6 +210,14 @@ impl<T: Settings> std::hash::Hash for SettingID<T> {
210210
}
211211
}
212212

213+
impl<T: Settings> PartialEq for SettingID<T> {
214+
fn eq(&self, other: &Self) -> bool {
215+
self.id == other.id && self.name == other.name
216+
}
217+
}
218+
219+
impl<T: Settings> Eq for SettingID<T> {}
220+
213221
impl<T: Settings> SettingID<T> {
214222
pub const fn new(
215223
id: u32,

0 commit comments

Comments
 (0)