From fea03ed5a84823d4cf63156711258beed35f4614 Mon Sep 17 00:00:00 2001 From: baskaran284 Date: Fri, 24 Mar 2023 18:13:40 +0530 Subject: [PATCH] 1. Added null check to Compare class _eq and _neq checks. 2. Fixed BooleanCompare class to inherit from Compare class rather than NumberCompare. --- packages/vaex-graphql/vaex/graphql/__init__.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/vaex-graphql/vaex/graphql/__init__.py b/packages/vaex-graphql/vaex/graphql/__init__.py index abec1fa036..f12c82a931 100644 --- a/packages/vaex-graphql/vaex/graphql/__init__.py +++ b/packages/vaex-graphql/vaex/graphql/__init__.py @@ -72,9 +72,9 @@ def map_to_field(df, name): class Compare(graphene.InputObjectType): def filter(self, df, name): expression = vaex.expression.Expression(df, '(1==1)') - if self._eq: + if self._eq is not None: expression = expression & (df[name] == self._eq) - if self._neq: + if self._neq is not None: expression = expression & (df[name] != self._neq) return expression @@ -108,7 +108,7 @@ class FloatCompare(NumberCompare): _gte = graphene.Field(graphene.Float) _lte = graphene.Field(graphene.Float) -class BooleanCompare(NumberCompare): +class BooleanCompare(Compare): _eq = graphene.Field(graphene.Boolean) _neq = graphene.Field(graphene.Boolean)