diff --git a/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java b/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java index 2d3f58e4239..94f9e797284 100644 --- a/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java +++ b/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/main/java/com/vaadin/flow/component/datepicker/DatePicker.java @@ -249,7 +249,7 @@ public DatePicker(LocalDate initialDate) { * @see #setValue(Object) */ private DatePicker(LocalDate initialDate, boolean isInitialValueOptional) { - super("value", initialDate, String.class, PARSER, FORMATTER); + super("value", null, String.class, PARSER, FORMATTER); // Initialize property value unless it has already been set from a // template diff --git a/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java b/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java index 128ee66e443..298bddb99dd 100644 --- a/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java +++ b/vaadin-date-picker-flow-parent/vaadin-date-picker-flow/src/test/java/com/vaadin/flow/component/datepicker/DatePickerTest.java @@ -88,6 +88,18 @@ public void setInitialValue() { picker.getElement().getProperty("value")); } + @Test + public void emptyValueIsNull() { + DatePicker picker = new DatePicker(); + Assert.assertNull(picker.getEmptyValue()); + } + + @Test + public void setInitialValue_emptyValueIsNull() { + DatePicker picker = new DatePicker(LocalDate.of(2018, 4, 25)); + Assert.assertNull(picker.getEmptyValue()); + } + @Test public void updatingToNullValue_displaysEmptyString() { DatePicker picker = new DatePicker(); diff --git a/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java b/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java index a75c6565778..3561bb309af 100644 --- a/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java +++ b/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/main/java/com/vaadin/flow/component/timepicker/TimePicker.java @@ -218,7 +218,7 @@ public TimePicker(LocalTime time) { * ignored and the initial value is set */ private TimePicker(LocalTime time, boolean isInitialValueOptional) { - super("value", time, String.class, PARSER, FORMATTER); + super("value", null, String.class, PARSER, FORMATTER); // Initialize property value unless it has already been set from a // template diff --git a/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java b/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java index fb8ffcb6ec3..88f1d90aa09 100644 --- a/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java +++ b/vaadin-time-picker-flow-parent/vaadin-time-picker-flow/src/test/java/com/vaadin/flow/component/timepicker/tests/TimePickerTest.java @@ -79,6 +79,18 @@ public void timePicker_basicCases() { assertEquals(LocalTime.of(7, 40), picker.getValue()); } + @Test + public void emptyValueIsNull() { + TimePicker picker = new TimePicker(); + Assert.assertNull(picker.getEmptyValue()); + } + + @Test + public void setInitialValue_emptyValueIsNull() { + TimePicker picker = new TimePicker(LocalTime.of(5, 30)); + Assert.assertNull(picker.getEmptyValue()); + } + @Test public void timePicker_nullValue() { TimePicker timePicker = new TimePicker();