refactor: do not scroll by default on getrows and update javadocs

Author: ugur-vaadin

vaadin-grid-flow-parent/vaadin-grid-flow-integration-tests/src/test/java/com/vaadin/flow/component/grid/it/ComponentColumnWithHeightIT.java

@@ -54,14 +54,14 @@ public void shouldPositionItemsCorrectlyAfterUpdatingComponentRenderers() {
 
     @Test
     public void shouldPositionItemsCorrectlyAfterScrollingToEnd() {
-        int initialLastRow = grid.getRowCount() - 1;
-        var row = grid.getRow(initialLastRow);
-        int expected = row.getLocation().y + row.getSize().height;
+        var initialLastRow = grid.getRowCount() - 1;
+        var row = grid.getRow(initialLastRow, true);
+        var expectedPosition = row.getLocation().y + row.getSize().height;
 
         add.click();
         // Expect the y position of the last row to equal the y position + the
         // height of the previous row
-        Assert.assertEquals(expected,
-                grid.getRow(initialLastRow + 1, false).getLocation().y);
+        Assert.assertEquals(expectedPosition,
+                grid.getRow(initialLastRow + 1).getLocation().y);
     }
 }

vaadin-grid-flow-parent/vaadin-grid-testbench/src/main/java/com/vaadin/flow/component/grid/testbench/GridElement.java

@@ -234,26 +234,32 @@ public List<GridTRElement> getRows(int firstRowIndex, int lastRowIndex)
     }
 
     /**
-     * Gets the <code>tr</code> element for the given row index.
+     * Gets the {@code tr} element for the given row index.
      *
      * @param rowIndex
      *            the row index
-     * @return the tr element for the row
+     * @return the {@code tr} element for the row, or {@code null} if the row is
+     *         not in viewport
      * @throws IndexOutOfBoundsException
      *             if no row with given index exists
      */
     public GridTRElement getRow(int rowIndex) throws IndexOutOfBoundsException {
-        return getRow(rowIndex, true);
+        return getRow(rowIndex, false);
     }
 
     /**
-     * Gets the <code>tr</code> element for the given row index.
+     * Gets the {@code tr} element for the given row index.
+     * <p>
+     * Returns {@code null} if the row is not in viewport and the provided
+     * {@code scroll} parameter is {@code false}.
      *
      * @param rowIndex
      *            the row index
      * @param scroll
-     *            scroll to index to reveal the row
-     * @return the tr element for the row
+     *            whether to scroll to the row index
+     * @return the {@code tr} element for the row, or {@code null} if the row is
+     *         not in viewport and the provided {@code scroll} parameter is
+     *         {@code false}
      * @throws IndexOutOfBoundsException
      *             if no row with given index exists
      */