chore: migrate from formatter plugin to spotless (#5036)

Author: vursen

pom.xml

@@ -19,6 +19,8 @@
 
         <drivers.dir>${project.basedir}/drivers</drivers.dir>
         <drivers.downloader.phase>pre-integration-test</drivers.downloader.phase>
+
+        <spotless.plugin.version>3.1.0</spotless.plugin.version>
     </properties>
 
     <!-- tag::spring-version[] -->
@@ -217,13 +219,17 @@
             </plugin>
 
             <plugin>
-                <groupId>net.revelc.code.formatter</groupId>
-                <artifactId>formatter-maven-plugin</artifactId>
-                <version>2.24.1</version>
+                <groupId>com.diffplug.spotless</groupId>
+                <artifactId>spotless-maven-plugin</artifactId>
+                <version>${spotless.plugin.version}</version>
                 <configuration>
-                    <configFile>https://raw.githubusercontent.com/vaadin/flow/main/eclipse/VaadinJavaConventions.xml</configFile>
-                    <skipHtmlFormatting>true</skipHtmlFormatting>
-                    <lineEnding>LF</lineEnding>
+                    <java>
+                        <eclipse>
+                            <file>https://raw.githubusercontent.com/vaadin/flow/main/eclipse/VaadinJavaConventions.xml</file>
+                        </eclipse>
+                        <endWithNewline/>
+                        <removeUnusedImports/>
+                    </java>
                 </configuration>
             </plugin>
         </plugins>

src/main/java/com/vaadin/demo/reference/componentinternals/basics/ChangeEvent.java

@@ -7,5 +7,5 @@ public class ChangeEvent extends ComponentEvent<TextField> {
     public ChangeEvent(TextField source, boolean fromClient) {
         super(source, fromClient);
     }
-    
+
 }

src/main/java/com/vaadin/demo/reference/componentinternals/basics/CustomTextField.java

@@ -5,9 +5,9 @@
 public class CustomTextField extends LabeledTextField {
 
     private final Element errorElement = new Element("span");
-    
+
     public CustomTextField() {
         super();
         getElement().appendChild(errorElement);
     }
-}
+}

src/main/java/com/vaadin/demo/reference/componentinternals/basics/LabeledTextField.java

@@ -13,4 +13,4 @@ public class LabeledTextField extends Component {
     public LabeledTextField() {
         getElement().appendChild(labelElement, inputElement);
     }
-}
+}

src/main/java/com/vaadin/demo/reference/componentinternals/basics/SetIdView.java

@@ -5,10 +5,10 @@
 public class SetIdView extends VerticalLayout {
 
     public SetIdView() {
-// tag::id[]
+        // tag::id[]
         var component = new ShoppingCartSummaryLabel();
         component.setId("my-component");
-// end::id[]
+        // end::id[]
     }
-    
+
 }

src/main/java/com/vaadin/demo/reference/componentinternals/basics/ShoppingCartSummaryLabel.java

@@ -16,13 +16,15 @@ public class ShoppingCartSummaryLabel extends Component {
     @Override
     protected void onAttach(AttachEvent attachEvent) {
         // This assumes the session already contains a ShopEventBus
-        var eventBus = attachEvent.getSession().getAttribute(ShopEventBus.class);
+        var eventBus = attachEvent.getSession()
+                .getAttribute(ShopEventBus.class);
         eventBus.register(eventHandler);
     }
 
     @Override
     protected void onDetach(DetachEvent detachEvent) {
-        var eventBus = detachEvent.getSession().getAttribute(ShopEventBus.class);
+        var eventBus = detachEvent.getSession()
+                .getAttribute(ShopEventBus.class);
         eventBus.unregister(eventHandler);
     }
 

src/main/java/com/vaadin/demo/reference/componentinternals/basics/TextField.java

@@ -15,10 +15,11 @@
 public class TextField extends Component {
 
     public TextField(String value) {
-        getElement().setProperty("value",value);
+        getElement().setProperty("value", value);
     }
-// end::basic[]
-// tag::events[]
+
+    // end::basic[]
+    // tag::events[]
     @Synchronize("change")
     public String getValue() {
         return getElement().getProperty("value");
@@ -33,7 +34,7 @@ public Registration addValueChangeListener(
             ComponentEventListener<ChangeEvent> listener) {
         return addListener(ChangeEvent.class, listener);
     }
-// end::events[]
-// tag::basic[]
+    // end::events[]
+    // tag::basic[]
 }
 // end::basic[]

src/main/java/com/vaadin/demo/reference/componentinternals/basics/UserNameLabel.java

@@ -10,7 +10,8 @@ public class UserNameLabel extends Component {
     @Override
     protected void onAttach(AttachEvent attachEvent) {
         // This assumes the username has been stored in the session after login
-        String userName = (String) attachEvent.getSession().getAttribute("username");
+        String userName = (String) attachEvent.getSession()
+                .getAttribute("username");
         getElement().setText("Hello %s, weclome back!".formatted(userName));
     }
 }

src/main/java/com/vaadin/demo/reference/componentinternals/element/UserInputExample.java

@@ -14,7 +14,8 @@ public UserInputExample() {
         textInput.setAttribute("placeholder", "Enter your name");
         // end::create[]
         // tag::listen[]
-        textInput.addPropertyChangeListener("value", "change", e -> {});
+        textInput.addPropertyChangeListener("value", "change", e -> {
+        });
         // end::listen[]
 
         // tag::process[]
@@ -25,7 +26,7 @@ public UserInputExample() {
             getElement().appendChild(response);
         });
         // end::process[]
-        
+
         getElement().appendChild(textInput, button);
     }
 }

src/main/java/com/vaadin/demo/reference/componentinternals/events/ChangeEvent.java

@@ -6,5 +6,5 @@ public class ChangeEvent extends ComponentEvent<TextField> {
 
     public ChangeEvent(TextField source, boolean fromClient) {
         super(source, fromClient);
-    }    
+    }
 }