From 6f7e181835cde9dcaea2b7a57a3c265edee28549 Mon Sep 17 00:00:00 2001 From: Mathias Bynens Date: Mon, 6 Nov 2017 11:13:52 -0500 Subject: [PATCH] Clarify names of generated bundles (#21) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * dist/run.js → dist/cli.js * dist/bundle.js → dist/browser.js --- .travis.yml | 2 +- CONTRIBUTING.md | 6 +++--- README.md | 8 ++++---- webpack.config.js | 4 ++-- 4 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.travis.yml b/.travis.yml index 2e810c57..20904364 100644 --- a/.travis.yml +++ b/.travis.yml @@ -5,7 +5,7 @@ node_js: - "8" script: - npm test - - node dist/run.js + - node dist/cli.js sudo: false branches: only: diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 990716a0..9158cf0a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -6,7 +6,7 @@ contributing, please read the ## Setup locally -> The Web Tooling Benchmark doesn't officially support any version of [Node](https://www.nodejs.org) prior to Node 8, it currently works with Node 6 and Node 7, but that might change at any point in time. +> The Web Tooling Benchmark doesn't officially support any version of [Node](https://www.nodejs.org/) prior to Node 8, it currently works with Node 6 and Node 7, but that might change at any point in time. To start developing on the Web Tooling Benchmark you only need to install its dependencies: @@ -22,8 +22,8 @@ There's no formal test suite yet. For now the process is roughly: - [ ] Check that `npm install` passes. - [ ] Check that `npm test` passes. -- [ ] Check that the suite runs in `node`, via `node src/cli`. -- [ ] Check that the suite runs in `d8` via `/path/to/d8 dist/run.js`. +- [ ] Check that the suite runs in `node`, via `node src/cli.js`. +- [ ] Check that the suite runs in `d8` via `/path/to/d8 dist/cli.js`. - [ ] Check that the browser bundle works by pointing your browser to `dist/index.html`. ## Creating a new benchmark diff --git a/README.md b/README.md index 17343eea..4660f604 100644 --- a/README.md +++ b/README.md @@ -26,10 +26,10 @@ To build the benchmark suite, run $ npm install ``` -assuming that you have a working [Node.js](https://nodejs.org) installation. -The command produces a bundled version that is suitable to run in JS shells -(i.e. `d8`, `jsc`, or `jsshell`) in `dist/run.js` and another bundle in -`dist/bundle.js` that is used by the browser version in `dist/index.html`. +assuming that you have a working [Node.js](https://nodejs.org) installation. Once +the command is done, it produces a bundled version that is suitable to run in +JS shells (i.e. `d8`, `jsc` or `jsshell`) in `dist/cli.js` and another bundle +in `dist/browser.js` that is used by the browser version in `dist/index.html`. ## Running diff --git a/webpack.config.js b/webpack.config.js index 34996be1..a20fe8b2 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -12,7 +12,7 @@ module.exports = [ context: path.resolve("src"), entry: "./cli.js", output: { - filename: "run.js", + filename: "cli.js", path: path.resolve("dist") }, bail: true, @@ -38,7 +38,7 @@ module.exports = [ context: path.resolve("src"), entry: "./bootstrap.js", output: { - filename: "bundle.js", + filename: "browser.js", path: path.resolve("dist") }, bail: true,