Skip to content

Commit 364e95a

Browse files
authored
Raise minimal grpcio-tools version to fix missing protobuf upperbound (#684)
* Raise minimal grpcio-tools version to fix missing protobuf upperbound [ML-10393](https://iguazio.atlassian.net/browse/ML-10393) * Delete impi
1 parent 46dadb9 commit 364e95a

File tree

2 files changed

+3
-28
lines changed

2 files changed

+3
-28
lines changed

Makefile

Lines changed: 1 addition & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -140,31 +140,5 @@ else
140140
$(error Please run `go fmt ./...` to format the code)
141141
endif
142142

143-
.PHONY: impi
144-
impi:
145-
@echo Installing impi...
146-
GO111MODULE=off go get -u github.com/pavius/impi/cmd/impi
147-
@echo Verifying imports...
148-
$(GOPATH)/bin/impi \
149-
--local github.com/iguazio/provazio \
150-
--skip pkg/controller/apis \
151-
--skip pkg/controller/client \
152-
--ignore-generated \
153-
--scheme stdLocalThirdParty \
154-
./...
155-
156-
$(GOPATH)/bin/golangci-lint:
157-
@echo Installing golangci-lint...
158-
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.49.0
159-
cp ./bin/golangci-lint $(GOPATH)/bin/
160-
161143
.PHONY: lint
162-
lint: gofmt impi $(GOPATH)/bin/golangci-lint
163-
@echo Linting...
164-
@$(GOPATH)/bin/golangci-lint run \
165-
--disable-all --enable=deadcode --enable=goconst --enable=golint --enable=ineffassign \
166-
--enable=interfacer --enable=unconvert --enable=varcheck --enable=errcheck --enable=gofmt --enable=misspell \
167-
--enable=staticcheck --enable=gosimple --enable=govet --enable=goconst \
168-
--timeout=10m \
169-
api/... backends/... cmd/... framulate/... grpc/... http/... repeatingtask/... v3ioutils/...
170-
@echo done linting
144+
lint: gofmt

clients/py/requirements.txt

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
googleapis-common-protos>=1.5.3
22
# grpcio-tools 1.34.0 must not be used as it segfaults (1.34.1 ok).
33
# grpcio-tools 1.49 raises protobuf version from 3.x to 4.x, which breaks compatibility.
4-
grpcio-tools>=1.30,!=1.34.0,<1.49
4+
# grpcio-tools 1.30.0 lacks a protobuf upperbound, which was added in 1.31.0
5+
grpcio-tools>=1.31,!=1.34.0,<1.49
56
protobuf<4
67
pandas>=0.23.4
78
requests>=2.19.1

0 commit comments

Comments
 (0)