Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Break out model-dependent properties into a new baseclass. #3

Closed
bsmithyman opened this issue Nov 23, 2015 · 2 comments
Closed

[CLOSED] Break out model-dependent properties into a new baseclass. #3

bsmithyman opened this issue Nov 23, 2015 · 2 comments

Comments

@bsmithyman
Copy link
Member

Issue by bsmithyman
Monday Nov 09, 2015 at 23:49 GMT
Originally opened as uwoseis/anemoi#3

Model-dependent properties are now part of a new baseclass, which means that we have something to inherit from when we want features dealing with model size, etc., but not other aspects of something like BaseDiscretization.

bsmithyman included the following code: https://github.com/uwoseis/anemoi/pull/3/commits
@bsmithyman
Copy link
Member Author

Comment by ShaunHadden
Thursday Nov 12, 2015 at 17:36 GMT

did i forget to do this? my apologies Brendan!

@bsmithyman
Copy link
Member Author

Comment by bsmithyman
Thursday Nov 12, 2015 at 19:20 GMT

No problem! I'm doing this partly to make sure you know what's going on, and partly for documentation purposes. That way there's discussion & context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsmithyman