remove unused header arguments from request methods

Author: uwolfer

src/main/java/com/urswolfer/gerrit/client/rest/http/GerritRestClient.java

@@ -48,7 +48,10 @@
 import java.io.InputStream;
 import java.io.InputStreamReader;
 import java.io.Reader;
-import java.util.*;
+import java.util.Arrays;
+import java.util.Date;
+import java.util.List;
+import java.util.Set;
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
@@ -91,29 +94,29 @@ public Gson getGson() {
         return GSON;
     }
 
-    public JsonElement getRequest(String path, Header... headers) throws RestApiException {
-        return request(path, null, Arrays.asList(headers), HttpVerb.GET);
+    public JsonElement getRequest(String path) throws RestApiException {
+        return request(path, null, HttpVerb.GET);
     }
 
-    public JsonElement postRequest(String path, String requestBody, Header... headers) throws RestApiException {
-        return request(path, requestBody, Arrays.asList(headers), HttpVerb.POST);
+    public JsonElement postRequest(String path, String requestBody) throws RestApiException {
+        return request(path, requestBody, HttpVerb.POST);
     }
 
-    public JsonElement putRequest(String path, Header... headers) throws RestApiException {
-        return putRequest(path, null, headers);
+    public JsonElement putRequest(String path) throws RestApiException {
+        return putRequest(path, null);
     }
 
-    public JsonElement putRequest(String path, String requestBody, Header... headers) throws RestApiException {
-        return request(path, requestBody, Arrays.asList(headers), HttpVerb.PUT);
+    public JsonElement putRequest(String path, String requestBody) throws RestApiException {
+        return request(path, requestBody, HttpVerb.PUT);
     }
 
-    public JsonElement deleteRequest(String path, Header... headers) throws RestApiException {
-        return request(path, null, Arrays.asList(headers), HttpVerb.DELETE);
+    public JsonElement deleteRequest(String path) throws RestApiException {
+        return request(path, null, HttpVerb.DELETE);
     }
 
-    public JsonElement request(String path, String requestBody, Collection<Header> headers, HttpVerb verb) throws RestApiException {
+    public JsonElement request(String path, String requestBody, HttpVerb verb) throws RestApiException {
         try {
-            HttpResponse response = doRest(path, requestBody, headers, verb);
+            HttpResponse response = doRest(path, requestBody, verb);
 
             checkStatusCode(response);
 
@@ -132,7 +135,7 @@ public JsonElement request(String path, String requestBody, Collection<Header> h
         }
     }
 
-    public HttpResponse doRest(String path, String requestBody, Collection<Header> headers, HttpVerb verb) throws IOException, RestApiException {
+    public HttpResponse doRest(String path, String requestBody, HttpVerb verb) throws IOException, RestApiException {
         HttpContext httpContext = new BasicHttpContext();
         HttpClientBuilder client = getHttpClient(httpContext);
 
@@ -165,9 +168,6 @@ public HttpResponse doRest(String path, String requestBody, Collection<Header> h
             default:
                 throw new IllegalStateException("Unknown or unsupported HttpVerb method: " + verb.toString());
         }
-        for (Header header : headers) {
-            method.addHeader(header);
-        }
         if (gerritAuthOptional.isPresent()) {
             method.addHeader("X-Gerrit-Auth", gerritAuthOptional.get());
         }

src/main/java/com/urswolfer/gerrit/client/rest/http/tools/ToolsRestClient.java

@@ -19,12 +19,10 @@
 import com.google.gerrit.extensions.restapi.RestApiException;
 import com.urswolfer.gerrit.client.rest.http.GerritRestClient;
 import com.urswolfer.gerrit.client.rest.tools.Tools;
-import org.apache.http.Header;
 import org.apache.http.HttpResponse;
 
 import java.io.IOException;
 import java.io.InputStream;
-import java.util.Collections;
 
 /**
  * @author Urs Wolfer
@@ -40,7 +38,7 @@ public ToolsRestClient(GerritRestClient gerritRestClient) {
     @Override
     public InputStream getCommitMessageHook() throws RestApiException {
         try {
-            HttpResponse response = gerritRestClient.doRest("/tools/hooks/commit-msg", null, Collections.<Header>emptyList(), GerritRestClient.HttpVerb.GET);
+            HttpResponse response = gerritRestClient.doRest("/tools/hooks/commit-msg", null, GerritRestClient.HttpVerb.GET);
             int statusCode = response.getStatusLine().getStatusCode();
             if (statusCode >= 200 && statusCode < 400) {
                 return response.getEntity().getContent();