build-gnu.sh: Use multicall binary for faster build time

[oech3]

Individual bins are slow to build.
#9310

[oech3]

@ChrisX101010 What utils am I missing at #9567 ? I don't need 100% minimal set. It should save 5 min+/ 1 CI run.

[ChrisX101010]

@ChrisX101010 What utils am I missing at #9567 ? I don't need 100% minimal set. It should save 5 min+/ 1 CI run.

Hey @oech3 I think first we need to fix broken du.rs script needs to correctly handle symlinks with -L flag and second issue is when you run tests with minimal set: UTILS="du ln mkdir rm rmdir touch echo ls" it excludes the SELinux utils: chcon, id, runcon, getfattr, setfattr

[ChrisX101010]

@ChrisX101010 What utils am I missing at #9567 ? I don't need 100% minimal set. It should save 5 min+/ 1 CI run.

Maybe include: UTILS="du ln mkdir rm rmdir touch cp mv ls cat echo basename test chcon id runcon getfattr setfattr install mktemp printf env tr" ?

[oech3]

Thankyou. getfattr setfattr is not coreutils btw. Also I noticed that whoami seems used.

[oech3]

But not enough...

[ChrisX101010]

Thankyou. getfattr setfattr is not coreutils btw. Also I noticed that whoami seems used.

ah you are right i apologize, so I guess these need to be added to SELinux utils? UTILS="du ln mkdir rm touch chcon id runcon ls cp" and also it should be enabled in build command:
cargo build --features "feat_selinux" -p uu_du
Or for all utilities
cargo build --features "feat_selinux"

[oech3]

--features are managed by build-gnu.sh. attr is installed via CI.
But runner's GNU coreutils are not used by its framework (deliberately blocked?).

[ChrisX101010]

--features are managed by build-gnu.sh. attr is installed via CI. But runner's GNU coreutils are not used by its framework (deliberately blocked?).

export SKIP_TESTS="tests/ls/selinux tests/misc/selinux" for now?

[oech3]

No. Regression for faster build time would not accepted. PR should have advantage only.

[ChrisX101010]

No. Regression for faster build time would not accepted. PR should have advantage only.

build-gnu.sh script has this build logic: "${MAKE}" PROFILE="${PROFILE}" SKIP_UTILS=more CARGOFLAGS="${CARGO_FEATURE_FLAGS}" , maybe this SKIP_UTILS=more it skips the SELinux utils, and perhaps this should be better logic: if [ "${SELINUX_ENABLED}" = 1 ]; then "${MAKE}" UTILS="chcon id runcon ls cp mkdir rm touch whoami" PROFILE="${PROFILE}" CARGOFLAGS="${CARGO_FEATURE_FLAGS}" else "${MAKE}" PROFILE="${PROFILE}" SKIP_UTILS=more CARGOFLAGS="${CARGO_FEATURE_FLAGS}" fi

[ChrisX101010]

because the CI will run these two getfattr setfattr in system versions since they are external not part of coreutils, I doubt this is an issue.

[oech3]

UTILS you (and I) listed is still incomplete (and difficult to grep strict UTILS from GNU test suite probably). Extending SKIP_UTILS is reasonable. but difficult to save many...

[ChrisX101010]

UTILS you (and I) listed is still incomplete (and difficult to grep strict UTILS from GNU test suite probably).

Extending SKIP_UTILS is reasonable. but difficult to save many...

ohhhhh let me check, I wish I worked on this earlier, sorry been busy just all week.. Maybeee this can work while keeping the build time faster..?

• Final UTILS list:
  UTILS="du ln whoami basename cat chcon cp echo env id ln ls mkdir mkfifo mknod mktemp mv printf rm rmdir runcon stat test touch tr uname"

• Build script:
  "${MAKE}" UTILS="$UTILS" PROFILE="${PROFILE}" CARGOFLAGS="${CARGO_FEATURE_FLAGS}"

• Optional stubs:

    if [ ! -f "${UU_BUILD_DIR}/${cmd}" ]; then
        echo "#!/bin/sh" > "${UU_BUILD_DIR}/${cmd}"
        echo "# Stub for $cmd" >> "${UU_BUILD_DIR}/${cmd}"
        echo "exit 0" >> "${UU_BUILD_DIR}/${cmd}"
        chmod +x "${UU_BUILD_DIR}/${cmd}"
    fi
done```

[ChrisX101010]

UTILS you (and I) listed is still incomplete (and difficult to grep strict UTILS from GNU test suite probably).

Extending SKIP_UTILS is reasonable. but difficult to save many...

Can you try installing lib for SELinux:
sudo apt-get update
sudo apt-get install -y libselinux1-dev libselinux-dev