Merge branch 'main' into patch-3

Author: oech3

.github/workflows/freebsd.yml

@@ -43,7 +43,7 @@ jobs:
       with:
         disable_annotations: true
     - name: Prepare, build and test
-      uses: vmactions/[email protected].8
+      uses: vmactions/[email protected].9
       with:
         usesh: true
         sync: rsync
@@ -139,7 +139,7 @@ jobs:
       with:
         disable_annotations: true
     - name: Prepare, build and test
-      uses: vmactions/[email protected].8
+      uses: vmactions/[email protected].9
       with:
         usesh: true
         sync: rsync

src/common/validation.rs

@@ -25,7 +25,7 @@ pub fn get_all_utilities<T: Args>(
 
 /// Prints a "utility not found" error and exits
 pub fn not_found(util: &OsStr) -> ! {
-    println!("{}: function/utility not found", util.maybe_quote());
+    eprintln!("{}: function/utility not found", util.maybe_quote());
     process::exit(1);
 }
 
@@ -51,9 +51,9 @@ fn get_canonical_util_name(util_name: &str) -> &str {
         "[" => "test",
 
         // hashsum aliases - all these hash commands are aliases for hashsum
-        "md5sum" | "sha1sum" | "sha224sum" | "sha256sum" | "sha384sum" | "sha512sum"
-        | "sha3sum" | "sha3-224sum" | "sha3-256sum" | "sha3-384sum" | "sha3-512sum"
-        | "shake128sum" | "shake256sum" | "b2sum" | "b3sum" => "hashsum",
+        "md5sum" | "sha1sum" | "sha224sum" | "sha256sum" | "sha384sum" | "sha512sum" | "b2sum" => {
+            "hashsum"
+        }
 
         "dir" => "ls", // dir is an alias for ls
 

src/uu/install/src/install.rs

@@ -338,7 +338,7 @@ fn behavior(matches: &ArgMatches) -> UResult<Behavior> {
 
     let specified_mode: Option<u32> = if matches.contains_id(OPT_MODE) {
         let x = matches.get_one::<String>(OPT_MODE).ok_or(1)?;
-        Some(mode::parse(x, considering_dir, 0).map_err(|err| {
+        Some(uucore::mode::parse(x, considering_dir, 0).map_err(|err| {
             show_error!(
                 "{}",
                 translate!("install-error-invalid-mode", "error" => err)

src/uu/install/src/mode.rs

@@ -4,32 +4,8 @@
 // file that was distributed with this source code.
 use std::fs;
 use std::path::Path;
-#[cfg(not(windows))]
-use uucore::mode;
 use uucore::translate;
 
-/// Takes a user-supplied string and tries to parse to u16 mode bitmask.
-/// Supports comma-separated mode strings like "ug+rwX,o+rX" (same as chmod).
-pub fn parse(mode_string: &str, considering_dir: bool, umask: u32) -> Result<u32, String> {
-    // Split by commas and process each mode part sequentially
-    let mut current_mode: u32 = 0;
-
-    for mode_part in mode_string.split(',') {
-        let mode_part = mode_part.trim();
-        if mode_part.is_empty() {
-            continue;
-        }
-
-        current_mode = if mode_part.chars().any(|c| c.is_ascii_digit()) {
-            mode::parse_numeric(current_mode, mode_part, considering_dir)?
-        } else {
-            mode::parse_symbolic(current_mode, mode_part, umask, considering_dir)?
-        };
-    }
-
-    Ok(current_mode)
-}
-
 /// chmod a file or directory on UNIX.
 ///
 /// Adapted from mkdir.rs.  Handles own error printing.
@@ -55,128 +31,3 @@ pub fn chmod(path: &Path, mode: u32) -> Result<(), ()> {
     // chmod on Windows only sets the readonly flag, which isn't even honored on directories
     Ok(())
 }
-
-#[cfg(test)]
-#[cfg(not(windows))]
-mod tests {
-    use super::parse;
-
-    #[test]
-    fn test_parse_numeric_mode() {
-        // Simple numeric mode
-        assert_eq!(parse("644", false, 0).unwrap(), 0o644);
-        assert_eq!(parse("755", false, 0).unwrap(), 0o755);
-        assert_eq!(parse("777", false, 0).unwrap(), 0o777);
-        assert_eq!(parse("600", false, 0).unwrap(), 0o600);
-    }
-
-    #[test]
-    fn test_parse_numeric_mode_with_operator() {
-        // Numeric mode with + operator
-        assert_eq!(parse("+100", false, 0).unwrap(), 0o100);
-        assert_eq!(parse("+644", false, 0).unwrap(), 0o644);
-
-        // Numeric mode with - operator (starting from 0, so nothing to remove)
-        assert_eq!(parse("-4", false, 0).unwrap(), 0);
-        // But if we first set a mode, then remove bits
-        assert_eq!(parse("644,-4", false, 0).unwrap(), 0o640);
-    }
-
-    #[test]
-    fn test_parse_symbolic_mode() {
-        // Simple symbolic modes
-        assert_eq!(parse("u+x", false, 0).unwrap(), 0o100);
-        assert_eq!(parse("g+w", false, 0).unwrap(), 0o020);
-        assert_eq!(parse("o+r", false, 0).unwrap(), 0o004);
-        assert_eq!(parse("a+x", false, 0).unwrap(), 0o111);
-    }
-
-    #[test]
-    fn test_parse_symbolic_mode_multiple_permissions() {
-        // Multiple permissions in one mode
-        assert_eq!(parse("u+rw", false, 0).unwrap(), 0o600);
-        assert_eq!(parse("ug+rwx", false, 0).unwrap(), 0o770);
-        assert_eq!(parse("a+rwx", false, 0).unwrap(), 0o777);
-    }
-
-    #[test]
-    fn test_parse_comma_separated_modes() {
-        // Comma-separated mode strings (as mentioned in the doc comment)
-        assert_eq!(parse("ug+rwX,o+rX", false, 0).unwrap(), 0o664);
-        assert_eq!(parse("u+rwx,g+rx,o+r", false, 0).unwrap(), 0o754);
-        assert_eq!(parse("u+w,g+w,o+w", false, 0).unwrap(), 0o222);
-    }
-
-    #[test]
-    fn test_parse_comma_separated_with_spaces() {
-        // Comma-separated with spaces (should be trimmed)
-        assert_eq!(parse("u+rw, g+rw, o+r", false, 0).unwrap(), 0o664);
-        assert_eq!(parse(" u+x , g+x ", false, 0).unwrap(), 0o110);
-    }
-
-    #[test]
-    fn test_parse_mixed_numeric_and_symbolic() {
-        // Mix of numeric and symbolic modes
-        assert_eq!(parse("644,u+x", false, 0).unwrap(), 0o744);
-        assert_eq!(parse("u+rw,755", false, 0).unwrap(), 0o755);
-    }
-
-    #[test]
-    fn test_parse_empty_string() {
-        // Empty string should return 0
-        assert_eq!(parse("", false, 0).unwrap(), 0);
-        assert_eq!(parse("   ", false, 0).unwrap(), 0);
-        assert_eq!(parse(",,", false, 0).unwrap(), 0);
-    }
-
-    #[test]
-    fn test_parse_with_umask() {
-        // Test with umask (affects symbolic modes when no level is specified)
-        let umask = 0o022;
-        assert_eq!(parse("+w", false, umask).unwrap(), 0o200);
-        // The umask should be respected for symbolic modes without explicit level
-    }
-
-    #[test]
-    fn test_parse_considering_dir() {
-        // Test directory vs file mode differences
-        // For directories, X (capital X) should add execute permission
-        assert_eq!(parse("a+X", true, 0).unwrap(), 0o111);
-        // For files without execute, X should not add execute
-        assert_eq!(parse("a+X", false, 0).unwrap(), 0o000);
-
-        // Numeric modes for directories preserve setuid/setgid bits
-        assert_eq!(parse("755", true, 0).unwrap(), 0o755);
-    }
-
-    #[test]
-    fn test_parse_invalid_modes() {
-        // Invalid numeric mode (too large)
-        assert!(parse("10000", false, 0).is_err());
-
-        // Invalid operator
-        assert!(parse("u*rw", false, 0).is_err());
-
-        // Invalid symbolic mode
-        assert!(parse("invalid", false, 0).is_err());
-    }
-
-    #[test]
-    fn test_parse_complex_combinations() {
-        // Complex real-world examples
-        assert_eq!(parse("u=rwx,g=rx,o=r", false, 0).unwrap(), 0o754);
-        // To test removal, we need to first set permissions, then remove them
-        assert_eq!(parse("644,a-w", false, 0).unwrap(), 0o444);
-        assert_eq!(parse("644,g-r", false, 0).unwrap(), 0o604);
-    }
-
-    #[test]
-    fn test_parse_sequential_application() {
-        // Test that comma-separated modes are applied sequentially
-        // First set to 644, then add execute for user
-        assert_eq!(parse("644,u+x", false, 0).unwrap(), 0o744);
-
-        // First add user write, then set to 755 (should override)
-        assert_eq!(parse("u+w,755", false, 0).unwrap(), 0o755);
-    }
-}

src/uu/mkdir/src/mkdir.rs

@@ -57,20 +57,11 @@ fn get_mode(_matches: &ArgMatches) -> Result<u32, String> {
 #[cfg(not(windows))]
 fn get_mode(matches: &ArgMatches) -> Result<u32, String> {
     // Not tested on Windows
-    let mut new_mode = DEFAULT_PERM;
-
     if let Some(m) = matches.get_one::<String>(options::MODE) {
-        for mode in m.split(',') {
-            if mode.chars().any(|c| c.is_ascii_digit()) {
-                new_mode = mode::parse_numeric(new_mode, m, true)?;
-            } else {
-                new_mode = mode::parse_symbolic(new_mode, mode, mode::get_umask(), true)?;
-            }
-        }
-        Ok(new_mode)
+        mode::parse_chmod(DEFAULT_PERM, m, true, mode::get_umask())
     } else {
         // If no mode argument is specified return the mode derived from umask
-        Ok(!mode::get_umask() & 0o0777)
+        Ok(!mode::get_umask() & DEFAULT_PERM)
     }
 }
 

src/uu/mkfifo/src/mkfifo.rs

@@ -119,19 +119,11 @@ pub fn uu_app() -> Command {
 
 fn calculate_mode(mode_option: Option<&String>) -> Result<u32, String> {
     let umask = uucore::mode::get_umask();
-    let mut mode = 0o666; // Default mode for FIFOs
+    let mode = 0o666; // Default mode for FIFOs
 
     if let Some(m) = mode_option {
-        if m.chars().any(|c| c.is_ascii_digit()) {
-            mode = uucore::mode::parse_numeric(mode, m, false)?;
-        } else {
-            for item in m.split(',') {
-                mode = uucore::mode::parse_symbolic(mode, item, umask, false)?;
-            }
-        }
+        uucore::mode::parse_chmod(mode, m, false, umask)
     } else {
-        mode &= !umask; // Apply umask if no mode is specified
+        Ok(mode & !umask) // Apply umask if no mode is specified
     }
-
-    Ok(mode)
 }

src/uu/mknod/src/mknod.rs

@@ -225,8 +225,10 @@ pub fn uu_app() -> Command {
         )
 }
 
+#[allow(clippy::unnecessary_cast)]
 fn parse_mode(str_mode: &str) -> Result<mode_t, String> {
-    uucore::mode::parse_mode(str_mode)
+    let default_mode = (S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH) as u32;
+    uucore::mode::parse_chmod(default_mode, str_mode, true, uucore::mode::get_umask())
         .map_err(|e| {
             translate!(
                 "mknod-error-invalid-mode",
@@ -237,7 +239,7 @@ fn parse_mode(str_mode: &str) -> Result<mode_t, String> {
             if mode > 0o777 {
                 Err(translate!("mknod-error-mode-permission-bits-only"))
             } else {
-                Ok(mode)
+                Ok(mode as mode_t)
             }
         })
 }

src/uu/ptx/src/ptx.rs

@@ -197,9 +197,6 @@ struct WordRef {
 
 #[derive(Debug, Error)]
 enum PtxError {
-    #[error("{}", translate!("ptx-error-dumb-format"))]
-    DumbFormat,
-
     #[error("{}", translate!("ptx-error-not-implemented", "feature" => (*.0)))]
     NotImplemented(&'static str),
 
@@ -216,8 +213,6 @@ fn get_config(matches: &clap::ArgMatches) -> UResult<Config> {
         config.gnu_ext = false;
         config.format = OutFormat::Roff;
         "[^ \t\n]+".clone_into(&mut config.context_regex);
-    } else {
-        return Err(PtxError::NotImplemented("GNU extensions").into());
     }
     if matches.contains_id(options::SENTENCE_REGEXP) {
         return Err(PtxError::NotImplemented("-S").into());
@@ -589,6 +584,69 @@ fn format_tex_line(
     output
 }
 
+fn format_dumb_line(
+    config: &Config,
+    word_ref: &WordRef,
+    line: &str,
+    chars_line: &[char],
+    reference: &str,
+) -> String {
+    let (tail, before, keyword, after, head) =
+        prepare_line_chunks(config, word_ref, line, chars_line, reference);
+
+    // Calculate the position for the left part
+    // The left part consists of tail (if present) + space + before
+    let left_part = if tail.is_empty() {
+        before
+    } else if before.is_empty() {
+        tail
+    } else {
+        format!("{tail} {before}")
+    };
+
+    // Calculate the position for the right part
+    let right_part = if head.is_empty() {
+        after
+    } else if after.is_empty() {
+        head
+    } else {
+        format!("{after} {head}")
+    };
+
+    // Calculate the width for the left half (before the keyword)
+    let half_width = config.line_width / 2;
+
+    // Right-justify the left part within the left half
+    let padding = if left_part.len() < half_width {
+        half_width - left_part.len()
+    } else {
+        0
+    };
+
+    // Build the output line with padding, left part, gap, keyword, and right part
+    let mut output = String::new();
+    output.push_str(&" ".repeat(padding));
+    output.push_str(&left_part);
+
+    // Add gap before keyword
+    output.push_str(&" ".repeat(config.gap_size));
+
+    output.push_str(&keyword);
+    output.push_str(&right_part);
+
+    // Add reference if needed
+    if config.auto_ref || config.input_ref {
+        if config.right_ref {
+            output.push(' ');
+            output.push_str(reference);
+        } else {
+            output = format!("{reference} {output}");
+        }
+    }
+
+    output
+}
+
 fn format_roff_field(s: &str) -> String {
     s.replace('\"', "\"\"")
 }
@@ -716,9 +774,13 @@ fn write_traditional_output(
                 &chars_lines[word_ref.local_line_nr],
                 &reference,
             ),
-            OutFormat::Dumb => {
-                return Err(PtxError::DumbFormat.into());
-            }
+            OutFormat::Dumb => format_dumb_line(
+                config,
+                word_ref,
+                &lines[word_ref.local_line_nr],
+                &chars_lines[word_ref.local_line_nr],
+                &reference,
+            ),
         };
         writeln!(writer, "{output_line}")
             .map_err_context(|| translate!("ptx-error-write-failed"))?;