Skip to content

make_fake_fixtures.py creates chapters whose member IDs overlap real members #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annabunches opened this issue Oct 12, 2020 · 1 comment
Labels
bug Bugs in our AGAGD system. good first issue

Comments

@annabunches
Copy link
Contributor

Summary of the Bug

In the prod AGAGD, the Chapters table has member_ids that correspond to a chapter-type member in the Members table. For example, https://agagd.usgo.org/chapter/NOVA/ corresponds to https://agagd.usgo.org/player/126/. In other words, the primary key field member_id is unique across both the Members and the Chapters table/model.

make_fake_fixtures.py, however, creates chapters with IDs that correspond to normal players.

Steps to Reproduce the Behaviour

i.e.,

  1. docker-compose down -v (this will delete any test data you currently have)
  2. docker-compose build
  3. docker-compose up

The Expected Behaviour

Chapters should ideally have corresponding Member objects with the same member_id.

Notes

This only affects local dev work, and only in very rare circumstances, so this should be a low priority issue.

@abaisero
Copy link
Contributor

abaisero commented Apr 6, 2022

I'm looking into this as a low-fruit contribution. It seems like a Chapter should also have a corresponding Member entry, but the fixture script does not currently make one. I think to fix this a corresponding Member entry should be created, but Member has many fields which I wouldn't know how to fill, e.g., given_names, family_name, occupation, citizen, etc.

image

If anybody is willing to give any guidance on how to fill those entries for a Chapter, I'd be happy to fix the fixtures, and make other improvements to the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs in our AGAGD system. good first issue
Projects
None yet
Development

No branches or pull requests

2 participants