Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase block confirmations before calling functions #3

Open
thomas779 opened this issue Nov 19, 2023 · 0 comments
Open

feat: increase block confirmations before calling functions #3

thomas779 opened this issue Nov 19, 2023 · 0 comments

Comments

@thomas779
Copy link
Member

thomas779 commented Nov 19, 2023 •
edited
Loading

Problem
Currently, events are emitted as soon as the first block is confirmed. A better security approach would be to wait for a couple of block confirmations after the event is emitted.

The risk the first block is malicious is low, but still good security practice to implement. Better safe than sorry.

Suggestion
Between 4 - 6.

Considerations
More block confirmation degrades UX and increases the relayer queue for concurrent users.
@thomas779 thomas779 changed the title feat: increase block confirmations feat: increase block confirmations before calling functions Nov 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thomas779