Fix test case for Sphinx < 8.2

Author: ubmarco

tests/test_needs_external_needs_build.py

@@ -5,6 +5,8 @@
 import pytest
 import responses
 from docutils import __version__ as doc_ver
+from sphinx import version_info
+from sphinx.testing.util import SphinxTestApp
 from sphinx.util.console import strip_colors
 
 
@@ -13,13 +15,11 @@
     [{"buildername": "html", "srcdir": "doc_test/doc_needs_external_needs"}],
     indirect=True,
 )
-def test_doc_build_html(test_app, sphinx_test_tempdir):
+def test_doc_build_html(test_app: SphinxTestApp, sphinx_test_tempdir):
     import subprocess
 
-    app = test_app
-
-    src_dir = Path(app.srcdir)
-    out_dir = Path(app.outdir)
+    src_dir = Path(test_app.srcdir)
+    out_dir = Path(test_app.outdir)
     plantuml = r"java -Djava.awt.headless=true -jar {}".format(
         os.path.join(sphinx_test_tempdir, "utils", "plantuml.jar")
     )
@@ -39,6 +39,12 @@ def test_doc_build_html(test_app, sphinx_test_tempdir):
         ["sphinx-build", "-b", "html", "-D", rf"plantuml={plantuml}", src_dir, out_dir],
         capture_output=True,
     )
+
+    # Sphinx 8.2 removed an early return in case no documents were updated in
+    # https://github.com/sphinx-doc/sphinx/pull/13236
+    # which leads to SN warnings not being emitted
+    if version_info < (8, 2):
+        expected_warnings = []
     assert (
         strip_colors(output_second.stderr.decode("utf-8")).splitlines()
         == expected_warnings