Skip to content

Commit 2e67ca2

Browse files
author
Martin Urban
committed
Update GHA II
1 parent e4dbfe1 commit 2e67ca2

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

.github/workflows/unix_like_wheels.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ jobs:
3636
- name: Setup Ubuntu
3737
if: runner.os == 'Linux'
3838
run: |
39-
sudo apt update -y && sudo apt-get install git build-essential libglew-dev libpng-dev libfreetype6-dev libxml2-dev libmsgpack-dev libglm-dev libnetcdf-dev autoconf
39+
sudo apt update -y && sudo apt-get install git build-essential libxmu-dev libxi-dev libgl-dev libglew-dev libpng-dev libfreetype6-dev libxml2-dev libmsgpack-dev libglm-dev libnetcdf-dev autoconf pearl -y
4040
4141
- name: Initialize vcpkg
4242
run: |

CMakeLists.txt

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ project(_cmd)
4343
# ----- OS specific section
4444
if (${PLATFORM} STREQUAL "WINDOWS")
4545
message("Running Windows build")
46-
find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
4746
add_library(opengl32 STATIC IMPORTED)
4847
set_target_properties(opengl32 PROPERTIES IMPORTED_LOCATION ${CMAKE_SOURCE_DIR}/pre-built/windows/libx64/OpenGL32.Lib)
4948

@@ -67,7 +66,6 @@ if (${PLATFORM} STREQUAL "WINDOWS")
6766
PYMOL_OPENMP
6867
# _HAVE_LIBXML # I had linker problems using this macro
6968
)
70-
set(Venv_Python_EXE ${CMAKE_SOURCE_DIR}/.venv/Scripts/python)
7169
endif ()
7270

7371
if (${PLATFORM} STREQUAL "DARWIN")
@@ -78,7 +76,6 @@ if (${PLATFORM} STREQUAL "DARWIN")
7876
set(LIB_DIR ${CMAKE_SOURCE_DIR}/vcpkg_installed/x64-osx/lib)
7977
endif ()
8078
# --- end
81-
find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
8279
find_package(OpenGL REQUIRED)
8380

8481
set(ALL_COMPILER_ARGS
@@ -105,14 +102,12 @@ if (${PLATFORM} STREQUAL "DARWIN")
105102
_PYMOL_OSX
106103
# PYMOL_OPENMP # Not used in Schrödinger's build
107104
)
108-
set(Venv_Python_EXE ${CMAKE_SOURCE_DIR}/.venv/bin/python)
105+
109106
endif ()
110107

111108
if (${PLATFORM} STREQUAL "GNU_LINUX")
112109
# Add Linux specific options here
113110
message("Running GNU Linux build")
114-
#find_package(Python3 ${PYTHON_VER} EXACT COMPONENTS Development REQUIRED)
115-
find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
116111
set(LIB_DIR ${CMAKE_SOURCE_DIR}/vcpkg_installed/x64-linux/lib)
117112

118113
add_library(opengl32 STATIC IMPORTED)
@@ -133,7 +128,6 @@ if (${PLATFORM} STREQUAL "GNU_LINUX")
133128
set (OS_SPECIFIC_COMPILER_DEFS
134129
_HAVE_LIBXML
135130
)
136-
set(Venv_Python_EXE ${CMAKE_SOURCE_DIR}/.venv/bin/python)
137131
endif ()
138132
# --- end
139133

@@ -377,7 +371,7 @@ set(ALL_SRC
377371
)
378372
python_add_library(_cmd MODULE WITH_SOABI ${ALL_SRC}) # Default target
379373
install(TARGETS _cmd DESTINATION pymol)
380-
374+
# add_library(_cmd MODULE ${ALL_SRC}) # Default CLion target
381375
# ----- Target compile section
382376
target_compile_options(_cmd PRIVATE ${ALL_COMPILER_ARGS})
383377
target_compile_features(_cmd PRIVATE cxx_std_17)
@@ -414,16 +408,22 @@ set (ALL_INCLUDE_DIR
414408
target_include_directories(_cmd PUBLIC ${ALL_INCLUDE_DIR})
415409
# --- end
416410

411+
# ----- Packages section
412+
find_package(Python COMPONENTS Interpreter Development.Module REQUIRED)
413+
# The variable for the Python target is needed, otherwise CLion
414+
# does not recognize the build target as valid target and therefore CMake fails.
415+
set(PY_LIB Python::Python)
417416
find_package(freetype CONFIG REQUIRED)
418417
find_package(glew CONFIG REQUIRED)
419418
find_package(PNG CONFIG REQUIRED)
420419
find_package(libxml2 CONFIG REQUIRED)
421420
find_package(netCDF CONFIG REQUIRED)
421+
# --- end
422422

423423
# ----- Linker section
424424
target_link_directories(_cmd PRIVATE ${LIB_DIR}) # Refactor LIB_DIR to something more meaningful
425425
target_link_options(_cmd PRIVATE ${OS_SPECIFIC_LINKER_OPTIONS})
426-
target_link_libraries(_cmd PRIVATE ${OS_SPECIFIC_LIBRARY_NAMES} Python)
426+
target_link_libraries(_cmd PRIVATE ${OS_SPECIFIC_LIBRARY_NAMES} ${PY_LIB})
427427
# --- end
428428

429429
# ----- Champ section
@@ -444,9 +444,9 @@ python_add_library(_champ MODULE WITH_SOABI ${ALL_CHAMP_SRC})
444444
# ----- Include section
445445
set(ALL_CHAMP_INCLUDE_DIR
446446
contrib/champ
447+
pre-built/include
447448
${OS_SPECIFIC_INCLUDES}
448449
${Python3_INCLUDE_DIRS}
449-
pre-built/include
450450
)
451451
target_include_directories(_champ PUBLIC ${ALL_INCLUDE_DIR})
452452
# --- end

0 commit comments

Comments
 (0)