-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up params #74
Comments
Is this still a thing? |
To my knowledge that's still a thing, yes. And here's a list of parameters that Greg had found that have only ursgal_style_1 translations and that we think are deprecated:
|
And then a few parameters that I think are XTandem parameters, but for some reason they don't have xtandem translation styles?
|
Some of the parameters are not actual parameters of the specified engines, e.g.:
base_mz is only used internally by Ursgal, not as a parameter within those engines (at least I'm very sure for most of them).
Similarly, there are inaccurate translations like this one:
"omssa_style_1": "frag_mass_tolerance_unit",
This should be either
"-to_part2"
(with"frag_mass_tolerance": "-to_part1"
) or should not be part of the parameters for omssa at all (which of course would be difficult for using it with anything else than Da).The text was updated successfully, but these errors were encountered: