Plugins using this resolver causes `node_modules` to not be removable whilst editor's ESLint is running

[SamuelT-Beslogic]

If https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint is running on a project with eslint-plugin-import-x and eslint-import-resolver-typescript, a lock is established on node_modules\@unrs\resolver-binding-win32-x64-msvc\resolver.win32-x64-msvc.node. Making it so any run that needs to remove this file (npm install after removing/updating these deps, or having to nuke the node_modules) will fail.

The current workaround is to manually disable the ESLint extension + restart the extension host (OR close the editor entirely), then try again.

(powershell error:)

System.UnauthorizedAccessException: Access to the path '...\node_modules\@unrs\resolver-binding-win32-x64-msvc\resolver.win32-x64-msvc.node' is denied.
   at Microsoft.PowerShell.Commands.FileSystemProvider.RemoveFileSystemItem(FileSystemInfo fileSystemInfo, Boolean force)

Dprint has a similar issue dprint/dprint-vscode#88 . That issue also mentions a possible workaround. Not sure if it applies here, but since this resolver is called by another plugin, maybe there's something to be done. If not then this is another note to an existing ecosystem-wide issue on Windows (I don't think unix-like systems have that issue).

I'm guessing there's probably nothing actionable in this repo, but that's where the symptoms happen, feel free to move/duplicate/link to the appropriate repository.

[JounQin]

Sorry I don't quite follow, why .node file is locked and by which process? vscode-eslint extension or VSCode itself?

---

By the way, shouldn't this be reported to VSCode instead?

[SamuelT-Beslogic]

.node file is locked and by which process?

According to Windows File Explorer, it's "opened in Visual Studio Code" (disabling the ESLint extension releases the file)

shouldn't this be reported to VSCode instead?

Probably, but I started where the symptoms show up. Thought you may appreciate knowing this is something users will run into. And just in case that's something that could be worked around at this level.

I just checked vscode-eslint and it seems to be this issue: microsoft/vscode-eslint#1806, which has the same answer as microsoft/vscode-eslint#1421 (comment)

[fredodiable]

Having a similar problem on Windows after each npm update since some months
Adding the command output if it can help

npm warn cleanup Failed to remove some directories [
npm warn cleanup   [
npm warn cleanup     'D:\\Dev\\Web\\media-tracker\\media-tracker-api\\node_modules\\@unrs\\.resolver-binding-win32-x64-msvc-MHmQv4ch',
npm warn cleanup     [Error: EPERM: operation not permitted, unlink 'D:\Dev\Web\media-tracker\media-tracker-api\node_modules\@unrs\.resolver-binding-win32-x64-msvc-MHmQv4ch\resolver.win32-x64-msvc.node'] {
npm warn cleanup       errno: -4048,
npm warn cleanup       code: 'EPERM',
npm warn cleanup       syscall: 'unlink',
npm warn cleanup       path: 'D:\\Dev\\Web\\media-tracker\\media-tracker-api\\node_modules\\@unrs\\.resolver-binding-win32-x64-msvc-MHmQv4ch\\resolver.win32-x64-msvc.node'
npm warn cleanup     }
npm warn cleanup   ]
npm warn cleanup ]

Fun fact I have 2 differents sub folder in @unrs both containing the file resolver.win32-x64-msvc.node

• .resolver-binding-win32-x64-msvc-MHmQv4ch contains outdated file
• resolver-binding-win32-x64-msvc contains the up to date file

if I close VSCode I can delete the outdated folder which should have been

[SamuelT-Beslogic]

Just for reference NX had this issue as well (not always in the context of the eslint extension, but that's where I've hit the issue w/ NX), They supposedly fixed it in v19 (I'm currently upgrading, so we'll see). Here's 3 potentially relevant PRs:

• 19.0.0 feat(core): load native files from tmp location instead of node_modules nrwl/nx#22648
• 19.1.0 fix(core): copy native files to tmp file location instead of .nx/cache nrwl/nx#23375
• 19.5.0 fix(core): ignore errors from cleanupNativeFileCache (revert to previous behaviour) nrwl/nx#26806