From fcf9fb50e3cea215a3d7ce29031be3d170e718f7 Mon Sep 17 00:00:00 2001
From: Martin Zikmund <martin@zikmund.dev>
Date: Wed, 18 Sep 2024 22:19:24 +0200
Subject: [PATCH 1/4] feat: Use AutoSuggestBox search

---
 .../Presentation/SampleChooserViewModel.cs    | 11 ++-
 .../Views/Controls/SampleChooserControl.xaml  | 68 +++++++++----------
 .../Controls/SampleChooserControl.xaml.cs     | 30 +++++++-
 .../Views/Entities/SampleSearchResult.cs      | 15 ++++
 .../SamplesApp.UnitTests.Shared.projitems     |  1 +
 5 files changed, 87 insertions(+), 38 deletions(-)
 create mode 100644 src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Entities/SampleSearchResult.cs

diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
index 8d85337f6e12..1feb1d6290ba 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
@@ -34,6 +34,7 @@
 using Private.Infrastructure;
 using System.Reflection.Metadata;
 using UITests.Shared.Helpers;
+using System.Runtime.CompilerServices;
 
 namespace SampleControl.Presentation
 {
@@ -437,6 +438,11 @@ internal void OpenPlayground()
 			SetSelectedSample(CancellationToken.None, "Playground", "Playground");
 		}
 
+		internal async Task OpenSample(CancellationToken ct, SampleChooserContent content)
+		{
+			(ContentPhone, _) = UpdateContent(ct, content);
+		}
+
 		internal async Task OpenRuntimeTests(CancellationToken ct)
 		{
 			IsSplitVisible = false;
@@ -629,13 +635,16 @@ private async Task<List<SampleChooserContent>> SearchAsync(string search, List<S
 			});
 		}
 
-		public void TryOpenSample()
+		public bool TryOpenSingleSearchResult()
 		{
 			if (FilteredSamples is { } samples
 				&& samples.Count is 1)
 			{
 				SelectedSearchSample = samples[0];
+				return true;
 			}
+
+			return false;
 		}
 
 		/// <summary>
diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml
index ecd277d1feef..81e9ec67e6d5 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml
@@ -7,6 +7,7 @@
 	xmlns:ub="using:Uno.UI.Samples.Behaviors"
 	xmlns:uc="using:Uno.UI.Samples.Converters"
 	xmlns:helper="using:Uno.UI.Samples.Behaviors"
+	xmlns:entities="using:SampleControl.Entities"
 	xmlns:ios="http://umbrella/ios"
 	xmlns:not_win="http://uno.ui/not_win"
 	xmlns:win="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
@@ -31,7 +32,7 @@
 			<x:Double x:Key="TitleContainerHeight">45</x:Double>
 
 			<uc:FromNullableBoolToReverseBoolConverter x:Key="reverseBoolConverter" />
-			
+
 			<!-- Styles -->
 			<Style x:Key="BaseTitleGridContainerStyle"
 				   TargetType="Grid">
@@ -245,6 +246,7 @@
 				  toolkit:VisibleBoundsPadding.PaddingMask="All">
 
 				<Grid.RowDefinitions>
+					<RowDefinition Height="Auto" />
 					<RowDefinition Height="Auto" />
 					<RowDefinition Height="*" />
 					<RowDefinition Height="Auto" />
@@ -276,7 +278,7 @@
 						<u:PathControl Style="{StaticResource Icon_RuntimeTests}"
 									   Margin="5,0" />
 					</Button>
-					
+
 					<!-- Playground button -->
 					<Button Style="{StaticResource IconButtonStyle}"
 							Foreground="{ThemeResource AccentFillColorDefaultBrush}"
@@ -318,8 +320,10 @@
 					<CheckBox Grid.Row="1" Grid.ColumnSpan="5" HorizontalAlignment="Center" 
 							  IsChecked="{Binding ManualTestsOnly, Mode=TwoWay}" Content="Manual tests only" />
 				</Grid>
+
+
 				<ContentControl ContentTemplate="{StaticResource CategoriesList}"
-								Grid.Row="1"
+								Grid.Row="2"
 								HorizontalContentAlignment="Stretch"
 								VerticalContentAlignment="Stretch"
 								Visibility="{Binding CategoryVisibility, Converter={StaticResource TrueToVisible}}" />
@@ -329,9 +333,11 @@
 								VerticalContentAlignment="Stretch"
 								Visibility="{Binding SampleVisibility, Converter={StaticResource TrueToVisible}}"
 								ContentTemplate="{StaticResource SamplesTitle}" />
+
+
 				<ContentControl HorizontalContentAlignment="Stretch"
 								VerticalContentAlignment="Stretch"
-								Grid.Row="1"
+								Grid.Row="2"
 								Visibility="{Binding SampleVisibility, Converter={StaticResource TrueToVisible}}"
 								ContentTemplate="{StaticResource SamplesList}" />
 
@@ -345,7 +351,7 @@
 				</Grid>
 				<ContentControl HorizontalContentAlignment="Stretch"
 								VerticalContentAlignment="Stretch"
-								Grid.Row="1"
+								Grid.Row="2"
 								Visibility="{Binding FavoritesVisibility, Converter={StaticResource TrueToVisible}}"
 								ContentTemplate="{StaticResource FavoritesList}" />
 
@@ -359,23 +365,27 @@
 				</Grid>
 				<ContentControl HorizontalContentAlignment="Stretch"
 								VerticalContentAlignment="Stretch"
-								Grid.Row="1"
+								Grid.Row="2"
 								Visibility="{Binding RecentsVisibility, Converter={StaticResource TrueToVisible}}"
 								ContentTemplate="{StaticResource RecentSamplesList}" />
 
-				<!--SEARCH-->
-				<Grid Style="{StaticResource BaseTitleGridContainerStyle}"
-					  Visibility="{Binding SearchVisibility, Converter={StaticResource TrueToVisible}}">
-					<TextBlock Style="{StaticResource Typo03}"
-							   VerticalAlignment="Center"
-							   HorizontalAlignment="Center"
-							   Text="Search" />
-				</Grid>
-				<ContentControl HorizontalContentAlignment="Stretch"
-								VerticalContentAlignment="Stretch"
-								Grid.Row="1"
-								Visibility="{Binding SearchVisibility, Converter={StaticResource TrueToVisible}}"
-								ContentTemplate="{StaticResource SearchList}" />
+				<!-- Search -->
+				<AutoSuggestBox PlaceholderText="Search..."
+					TextChanged="SearchBox_TextChanged"
+					TextMemberPath="ControlName"
+					QueryIcon="Find"
+					Grid.Row="1"
+					Margin="4,8"
+					ItemsSource="{Binding FilteredSamples}"
+					HorizontalAlignment="Stretch"
+					QuerySubmitted="SearchBox_QuerySubmitted"
+					SuggestionChosen="SearchBox_SuggestionChosen">
+					<AutoSuggestBox.ItemTemplate>
+						<DataTemplate x:DataType="entities:SampleChooserContent">
+							<TextBlock Text="{x:Bind ControlName}" />
+						</DataTemplate>
+					</AutoSuggestBox.ItemTemplate>
+				</AutoSuggestBox>
 
 				<!--NAVIGATION BUTTONS-->
 				<Border Background="{ThemeResource ApplicationPageBackgroundThemeBrush}"
@@ -383,9 +393,9 @@
 						BorderThickness="0,1,0,0"
 						BorderBrush="{StaticResource Color05Brush}"
 						Height="50"
-						Grid.Row="2">
+						Grid.Row="3">
 					<u:StarStackPanel VerticalAlignment="Stretch"
-									  Sizes="*,*,*,*"
+									  Sizes="*,*,*"
 									  Orientation="Horizontal">
 						<!--Button foreground has to be set by converter instead of Button's visual state
 							because path foreground doesn't change through visual states.-->
@@ -427,20 +437,6 @@
 										   Text="Recents" />
 							</StackPanel>
 						</RadioButton>
-
-						<RadioButton GroupName="SelectedSectionPhone"
-									 Style="{StaticResource SampleChooserNavRadioButtonStyle}"
-									 VerticalContentAlignment="Stretch"
-									 IsChecked="{Binding SearchSelected, Mode=TwoWay}"
-									 Command="{Binding ShowNewSectionCommand}"
-									 CommandParameter="Search">
-							<StackPanel VerticalAlignment="Center" Orientation="Vertical">
-								<FontIcon Glyph="&#xE721;" />
-								<TextBlock Style="{StaticResource Typo06}"
-										   VerticalAlignment="Bottom"
-										   Text="Search" />
-							</StackPanel>
-						</RadioButton>
 					</u:StarStackPanel>
 				</Border>
 			</Grid>
@@ -540,7 +536,7 @@
 							<FontIcon Glyph="&#xE734;" Visibility="{Binding CurrentSelectedSample.IsFavorite, Mode=OneWay, Converter={StaticResource TrueToCollapsed}}" />
 							<FontIcon Foreground="{ThemeResource AccentFillColorDefaultBrush}" Glyph="&#xE735;" Visibility="{Binding CurrentSelectedSample.IsFavorite, Mode=OneWay, Converter={StaticResource TrueToVisible}}" />
 						</Grid>
-						
+
 					</Button>
 
 					<!-- Dark theme check box -->
diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml.cs b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml.cs
index e5b21ced96f3..00778536bf31 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml.cs
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml.cs
@@ -8,6 +8,10 @@
 using Microsoft.UI.Xaml;
 using Microsoft.VisualStudio.TestTools.UnitTesting;
 using Microsoft.UI.Xaml.Input;
+using System.Threading;
+using SampleControl.Entities;
+
+
 #if WINAPPSDK
 using Windows.Foundation.Collections;
 using Microsoft.UI.Xaml.Controls;
@@ -63,7 +67,31 @@ private void OnSearchEnterKey_KeyDown(object sender, KeyRoutedEventArgs e)
 		{
 			if (e.Key == Windows.System.VirtualKey.Enter)
 			{
-				((SampleChooserViewModel)DataContext).TryOpenSample();
+				((SampleChooserViewModel)DataContext).TryOpenSingleSearchResult();
+			}
+		}
+
+		private void SearchBox_TextChanged(AutoSuggestBox sender, AutoSuggestBoxTextChangedEventArgs args)
+		{
+			if (args.Reason == AutoSuggestionBoxTextChangeReason.UserInput)
+			{
+				((SampleChooserViewModel)DataContext).SearchTerm = sender.Text;
+			}
+		}
+
+		private void SearchBox_QuerySubmitted(AutoSuggestBox sender, AutoSuggestBoxQuerySubmittedEventArgs args)
+		{
+			if (args is not null)
+			{
+				((SampleChooserViewModel)DataContext).TryOpenSingleSearchResult();
+			}
+		}
+
+		private void SearchBox_SuggestionChosen(AutoSuggestBox sender, AutoSuggestBoxSuggestionChosenEventArgs args)
+		{
+			if (args.SelectedItem is SampleChooserContent control)
+			{
+				_ = ((SampleChooserViewModel)DataContext).OpenSample(CancellationToken.None, control);
 			}
 		}
 	}
diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Entities/SampleSearchResult.cs b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Entities/SampleSearchResult.cs
new file mode 100644
index 000000000000..8271c4219848
--- /dev/null
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Entities/SampleSearchResult.cs
@@ -0,0 +1,15 @@
+using SampleControl.Entities;
+
+public class SampleSearchResult
+{
+	private readonly SampleChooserContent _content;
+
+	public SampleSearchResult(SampleChooserContent content)
+	{
+		_content = content;
+	}
+
+	public string Title => _content.ControlName;
+
+	public override string ToString() => Title;
+}
diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems b/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems
index b563b360b422..b058df279bca 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems
@@ -43,6 +43,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Converters\FromNullableToDefaultValueConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Converters\StringEmptyToVisibilityConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Converters\StringFormatConverter.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)controls\uitests\views\entities\SampleSearchResult.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Entities\Section.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Extensions\InputPanelExtensions.PanIntoView.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Helper\ContentNavigationBehavior.cs" />

From 9a1cda0af678e6c4e12bf38eb815046a54358df1 Mon Sep 17 00:00:00 2001
From: Martin Zikmund <martin@zikmund.dev>
Date: Wed, 18 Sep 2024 22:34:18 +0200
Subject: [PATCH 2/4] chore: Adjust UX

---
 .../Presentation/SampleChooserViewModel.cs    |  2 +-
 .../Views/Controls/SampleChooserControl.xaml  | 48 ++++++++++---------
 2 files changed, 26 insertions(+), 24 deletions(-)

diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
index 1feb1d6290ba..ae2bdcce152f 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
@@ -440,7 +440,7 @@ internal void OpenPlayground()
 
 		internal async Task OpenSample(CancellationToken ct, SampleChooserContent content)
 		{
-			(ContentPhone, _) = UpdateContent(ct, content);
+			(ContentPhone, _) = await UpdateContent(ct, content);
 		}
 
 		internal async Task OpenRuntimeTests(CancellationToken ct)
diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml
index 81e9ec67e6d5..0a2c915aca82 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Views/Controls/SampleChooserControl.xaml
@@ -39,11 +39,12 @@
 				<Setter Property="BorderBrush"
 						Value="{ThemeResource Color05Brush}" />
 				<Setter Property="BorderThickness"
-						Value="0,0,0,1" />
+						Value="0,0,0,0" />
+				<Setter Property="Margin" Value="4" />
 				<Setter Property="Background"
 						Value="{ThemeResource ApplicationPageBackgroundThemeBrush}" />
 				<Setter Property="Height"
-								Value="50" />
+								Value="36" />
 			</Style>
 
 			<Style x:Key="BaseTitleContainerStyle"
@@ -254,7 +255,6 @@
 
 				<!-- LIBRARY (Categories)-->
 				<Grid Style="{StaticResource BaseTitleGridContainerStyle}"
-					  Height="80"
 					  Visibility="{Binding CategoryVisibility, Converter={StaticResource TrueToVisible}}">
 
 					<Grid.ColumnDefinitions>
@@ -316,9 +316,6 @@
 						<u:PathControl Style="{StaticResource Icon_RunAll}"
 									   Margin="5,0" />
 					</Button>
-
-					<CheckBox Grid.Row="1" Grid.ColumnSpan="5" HorizontalAlignment="Center" 
-							  IsChecked="{Binding ManualTestsOnly, Mode=TwoWay}" Content="Manual tests only" />
 				</Grid>
 
 
@@ -369,23 +366,28 @@
 								Visibility="{Binding RecentsVisibility, Converter={StaticResource TrueToVisible}}"
 								ContentTemplate="{StaticResource RecentSamplesList}" />
 
-				<!-- Search -->
-				<AutoSuggestBox PlaceholderText="Search..."
-					TextChanged="SearchBox_TextChanged"
-					TextMemberPath="ControlName"
-					QueryIcon="Find"
-					Grid.Row="1"
-					Margin="4,8"
-					ItemsSource="{Binding FilteredSamples}"
-					HorizontalAlignment="Stretch"
-					QuerySubmitted="SearchBox_QuerySubmitted"
-					SuggestionChosen="SearchBox_SuggestionChosen">
-					<AutoSuggestBox.ItemTemplate>
-						<DataTemplate x:DataType="entities:SampleChooserContent">
-							<TextBlock Text="{x:Bind ControlName}" />
-						</DataTemplate>
-					</AutoSuggestBox.ItemTemplate>
-				</AutoSuggestBox>
+				<StackPanel Grid.Row="1" Spacing="4" Padding="4" BorderThickness="0,0,0,1"
+BorderBrush="{StaticResource Color05Brush}">
+					<!-- Search -->
+					<AutoSuggestBox PlaceholderText="Search..."
+						TextChanged="SearchBox_TextChanged"
+						TextMemberPath="ControlName"
+						QueryIcon="Find"
+						ItemsSource="{Binding FilteredSamples}"
+						HorizontalAlignment="Stretch"
+						QuerySubmitted="SearchBox_QuerySubmitted"
+						SuggestionChosen="SearchBox_SuggestionChosen">
+						<AutoSuggestBox.ItemTemplate>
+							<DataTemplate x:DataType="entities:SampleChooserContent">
+								<TextBlock Text="{x:Bind ControlName}" />
+							</DataTemplate>
+						</AutoSuggestBox.ItemTemplate>
+					</AutoSuggestBox>
+
+
+					<CheckBox Grid.Row="1" Grid.ColumnSpan="5" HorizontalAlignment="Center" 
+							  IsChecked="{Binding ManualTestsOnly, Mode=TwoWay}" Content="Manual tests only" />
+				</StackPanel>
 
 				<!--NAVIGATION BUTTONS-->
 				<Border Background="{ThemeResource ApplicationPageBackgroundThemeBrush}"

From b6537fc81c644c22bd63a5e8c0d53722d44df105 Mon Sep 17 00:00:00 2001
From: Martin Zikmund <martin@zikmund.dev>
Date: Wed, 18 Sep 2024 22:41:16 +0200
Subject: [PATCH 3/4] chore: Use default sample opening

---
 .../Controls/UITests/Presentation/SampleChooserViewModel.cs     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
index ae2bdcce152f..1dde0df59653 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UITests/Presentation/SampleChooserViewModel.cs
@@ -440,7 +440,7 @@ internal void OpenPlayground()
 
 		internal async Task OpenSample(CancellationToken ct, SampleChooserContent content)
 		{
-			(ContentPhone, _) = await UpdateContent(ct, content);
+			await SetSelectedSample(ct, content.ControlType.FullName);
 		}
 
 		internal async Task OpenRuntimeTests(CancellationToken ct)

From 69df36f4d40916784b622a7bae75e64512706c55 Mon Sep 17 00:00:00 2001
From: Martin Zikmund <martin@zikmund.dev>
Date: Mon, 30 Sep 2024 11:41:14 +0200
Subject: [PATCH 4/4] chore: Adjust casing in path

---
 .../SamplesApp.UnitTests.Shared.projitems                     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems b/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems
index b058df279bca..7222f941487c 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems
+++ b/src/SamplesApp/SamplesApp.UnitTests.Shared/SamplesApp.UnitTests.Shared.projitems
@@ -43,7 +43,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Converters\FromNullableToDefaultValueConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Converters\StringEmptyToVisibilityConverter.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Converters\StringFormatConverter.cs" />
-    <Compile Include="$(MSBuildThisFileDirectory)controls\uitests\views\entities\SampleSearchResult.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Entities\SampleSearchResult.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Entities\Section.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Extensions\InputPanelExtensions.PanIntoView.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Controls\UITests\Views\Helper\ContentNavigationBehavior.cs" />
@@ -133,4 +133,4 @@
   <ItemGroup>
     <None Include="$(MSBuildThisFileDirectory)SamplesApp.UnitTests.targets" />
   </ItemGroup>
-</Project>
\ No newline at end of file
+</Project>