fix(remote-control): Signal connection establishment once and handle keep-alive send exceptions

Author: carldebilly

src/Uno.UI.RemoteControl.VS/IDEChannel/IDEChannelClient.cs

@@ -57,6 +57,8 @@ public void ConnectToHost()
 				_devServer = JsonRpc.Attach<IIdeChannelServer>(_pipeServer);
 				_devServer.MessageFromDevServer += ProcessDevServerMessage;
 
+				// Signal connection established once
+				Connected?.Invoke(this, EventArgs.Empty);
 				ScheduleKeepAlive(ct);
 			}
 			catch (Exception e)
@@ -83,8 +85,6 @@ public async Task SendToDevServerAsync(IdeMessage message, CancellationToken ct)
 
 	private void ScheduleKeepAlive(CancellationToken ct)
 	{
-		Connected?.Invoke(this, EventArgs.Empty);
-
 		// Replace recursive re-scheduling with a single periodic timer
 		var oldTimer = Interlocked.Exchange(ref _keepAliveTimer, null);
 		oldTimer?.Dispose();
@@ -93,7 +93,22 @@ private void ScheduleKeepAlive(CancellationToken ct)
 		{
 			if (ct is { IsCancellationRequested: false } && _devServer is not null)
 			{
-				_ = _devServer.SendToDevServerAsync(IdeMessageSerializer.Serialize(new KeepAliveIdeMessage("IDE")), ct);
+				try
+				{
+					_ = _devServer
+						.SendToDevServerAsync(IdeMessageSerializer.Serialize(new KeepAliveIdeMessage("IDE")), ct)
+						.ContinueWith(t =>
+						{
+							if (t.IsFaulted && t.Exception is { } ex)
+							{
+								_logger.Verbose($"Keep-alive send failed: {ex.Flatten().Message}");
+							}
+						}, CancellationToken.None, TaskContinuationOptions.OnlyOnFaulted, TaskScheduler.Default);
+				}
+				catch (Exception ex)
+				{
+					_logger.Verbose($"Keep-alive send exception: {ex.Message}");
+				}
 			}
 			else
 			{
@@ -147,6 +162,12 @@ internal void Dispose()
 	{
 		_IDEChannelCancellation?.Cancel();
 		_keepAliveTimer?.Dispose();
+
+		if (_devServer is not null)
+		{
+			_devServer.MessageFromDevServer -= ProcessDevServerMessage;
+		}
+
 		_pipeServer?.Dispose();
 	}
 }