Rearrange internal helpers; fork SniffLocalCache

Author: colinodell

src/Unleashed/Helpers/SniffLocalCache.php

@@ -0,0 +1,47 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Unleashed\Helpers;
+
+use PHP_CodeSniffer\Files\File;
+
+/**
+ * @internal
+ *
+ * Forked from https://github.com/slevomat/coding-standard/blob/6.3.3/SlevomatCodingStandard/Helpers/SniffLocalCache.php
+ */
+final class SniffLocalCache
+{
+    /** @var array<int, array<string, mixed>> */
+    private static $cache = [];
+
+    /**
+     * @return mixed
+     */
+    public static function getAndSetIfNotCached(File $phpcsFile, string $key, \Closure $lazyValue)
+    {
+        $fixerLoops  = $phpcsFile->fixer !== null ? $phpcsFile->fixer->loops : 0;
+        $internalKey = \sprintf('%s-%s', $phpcsFile->getFilename(), $key);
+
+        self::setIfNotCached($fixerLoops, $internalKey, $lazyValue);
+
+        return self::$cache[$fixerLoops][$internalKey] ?? null;
+    }
+
+    private static function setIfNotCached(int $fixerLoops, string $internalKey, \Closure $lazyValue): void
+    {
+        if (
+            \array_key_exists($fixerLoops, self::$cache) &&
+            \array_key_exists($internalKey, self::$cache[$fixerLoops])
+        ) {
+            return;
+        }
+
+        self::$cache[$fixerLoops][$internalKey] = $lazyValue();
+
+        if ($fixerLoops > 0) {
+            unset(self::$cache[$fixerLoops - 1]);
+        }
+    }
+}

src/Unleashed/SniffHelper.php src/Unleashed/Helpers/UseStatements.phpsrc/Unleashed/SniffHelper.php renamed to src/Unleashed/Helpers/UseStatements.php

@@ -2,26 +2,22 @@
 
 declare(strict_types=1);
 
-namespace Unleashed;
+namespace Unleashed\Helpers;
 
 use PHP_CodeSniffer\Files\File;
-use SlevomatCodingStandard\Helpers\SniffLocalCache;
 use SlevomatCodingStandard\Helpers\UseStatement;
 use SlevomatCodingStandard\Helpers\UseStatementHelper;
 
 /**
  * @internal
  */
-final class SniffHelper
+final class UseStatements
 {
     /**
      * @return array<string,bool>
      */
     public static function getAliasesAndNonGlobalFunctionsDefinedInUseStatements(File $file): array
     {
-        static $cache;
-        $cache = $cache ?? new SniffLocalCache();
-
         $lazyValue = static function () use ($file): array {
             $result = [];
 
@@ -44,6 +40,6 @@ public static function getAliasesAndNonGlobalFunctionsDefinedInUseStatements(Fil
             return $result;
         };
 
-        return $cache->getAndSetIfNotCached($file, $lazyValue);
+        return SniffLocalCache::getAndSetIfNotCached($file, __METHOD__, $lazyValue);
     }
 }

src/Unleashed/Sniffs/Namespaces/FullyQualifiedGlobalFunctionsSniff.php

@@ -7,7 +7,7 @@
 use PHP_CodeSniffer\Files\File;
 use PHP_CodeSniffer\Sniffs\Sniff;
 use SlevomatCodingStandard\Sniffs\Classes\ModernClassNameReferenceSniff;
-use Unleashed\SniffHelper;
+use Unleashed\Helpers\UseStatements;
 
 final class FullyQualifiedGlobalFunctionsSniff implements Sniff
 {
@@ -96,7 +96,7 @@ public function process(File $phpcsFile, $stackPtr)
             $globalFunctions = \array_flip(\get_defined_functions()['internal']);
         }
 
-        $whitelist = SniffHelper::getAliasesAndNonGlobalFunctionsDefinedInUseStatements($phpcsFile);
+        $whitelist = UseStatements::getAliasesAndNonGlobalFunctionsDefinedInUseStatements($phpcsFile);
 
         $tokens    = $phpcsFile->getTokens();
         $ignore    = [

tests/Helpers/SniffHelperTest.php tests/Helpers/UseStatementsTest.phptests/Helpers/SniffHelperTest.php renamed to tests/Helpers/UseStatementsTest.php

@@ -1,17 +1,17 @@
 <?php
 
-namespace Helpers;
+namespace Unleashed\Tests\Helpers;
 
-use Unleashed\SniffHelper;
+use Unleashed\Helpers\UseStatements;
 use Unleashed\Tests\PHPCSTestCase;
 
-final class SniffHelperTest extends PHPCSTestCase
+final class UseStatementsTest extends PHPCSTestCase
 {
     public function testGetAliasesAndNonGlobalFunctionsDefinedInUseStatements()
     {
         $file = $this->getCodeSnifferFile(__DIR__ . '/data/useStatements.php');
 
-        $result = SniffHelper::getAliasesAndNonGlobalFunctionsDefinedInUseStatements($file);
+        $result = UseStatements::getAliasesAndNonGlobalFunctionsDefinedInUseStatements($file);
         $expected = [
             'stringlength',
             'isbar',